| Message ID | 20240831145450.3162934-1-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On Sat, 31 Aug 2024 16:54:49 +0200 Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > As reported in [1], version 1.9.2 has been moved to another archive, and > it is recommended to use https://github.com/jech/babeld as the official > repository. > > It was also necessary to change the sha of the downloaded tar.gz. > > Fixes: > - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 > > [1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > --- > Changes v1 -> v2: > - Don't bump to 1.10.0 but update the URL site. > > package/babeld/babeld.hash | 2 +- > package/babeld/babeld.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash > index 2e0513efa010..e725b1fe310c 100644 > --- a/package/babeld/babeld.hash > +++ b/package/babeld/babeld.hash > @@ -1,3 +1,3 @@ > # Locally computed > -sha256 154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07 babeld-1.9.2.tar.gz > +sha256 c8c8c3698afb00caa5a5c9bbbb0a22b56d79ad3f9775382915ba979ac88c4e8f babeld-1.9.2.tar.gz > sha256 b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd LICENCE > diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk > index 785fa2bce9f1..67d66da24f17 100644 > --- a/package/babeld/babeld.mk > +++ b/package/babeld/babeld.mk > @@ -5,7 +5,7 @@ > ################################################################################ > > BABELD_VERSION = 1.9.2 > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files > +BABELD_SITE = $(call github,jech,babeld,refs/tags) This looks odd. Isn't the version needed somewhere? Thomas
Hello Thomas, On Sat, Aug 31, 2024 at 6:25 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Sat, 31 Aug 2024 16:54:49 +0200 > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > > As reported in [1], version 1.9.2 has been moved to another archive, and > > it is recommended to use https://github.com/jech/babeld as the official > > repository. > > > > It was also necessary to change the sha of the downloaded tar.gz. > > > > Fixes: > > - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 > > > > [1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > Changes v1 -> v2: > > - Don't bump to 1.10.0 but update the URL site. > > > > package/babeld/babeld.hash | 2 +- > > package/babeld/babeld.mk | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash > > index 2e0513efa010..e725b1fe310c 100644 > > --- a/package/babeld/babeld.hash > > +++ b/package/babeld/babeld.hash > > @@ -1,3 +1,3 @@ > > # Locally computed > > -sha256 154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07 babeld-1.9.2.tar.gz > > +sha256 c8c8c3698afb00caa5a5c9bbbb0a22b56d79ad3f9775382915ba979ac88c4e8f babeld-1.9.2.tar.gz > > sha256 b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd LICENCE > > diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk > > index 785fa2bce9f1..67d66da24f17 100644 > > --- a/package/babeld/babeld.mk > > +++ b/package/babeld/babeld.mk > > @@ -5,7 +5,7 @@ > > ################################################################################ > > > > BABELD_VERSION = 1.9.2 > > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files > > +BABELD_SITE = $(call github,jech,babeld,refs/tags) > > This looks odd. Isn't the version needed somewhere? It seemed strange to me as well. Indeed, I don't see other similar _SITE settings in Buildroot. But if I go to the GitHub URL, these are the tarball addresses: https://github.com/jech/babeld/archive/refs/tags/babeld-1.9.2.tar.gz ... https://github.com/jech/babeld/archive/refs/tags/babeld-1.13.1.tar.gz Am I missing something? Thanks and regards, Dario > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com
Dario, All, On 2024-08-31 20:36 +0200, Dario Binacchi spake thusly: > On Sat, Aug 31, 2024 at 6:25 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > On Sat, 31 Aug 2024 16:54:49 +0200 > > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: [--SNIP--] > > > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files > > > +BABELD_SITE = $(call github,jech,babeld,refs/tags) > > This looks odd. Isn't the version needed somewhere? > It seemed strange to me as well. Indeed, I don't see other similar > _SITE settings in Buildroot. > But if I go to the GitHub URL, these are the tarball addresses: > https://github.com/jech/babeld/archive/refs/tags/babeld-1.9.2.tar.gz > ... > https://github.com/jech/babeld/archive/refs/tags/babeld-1.13.1.tar.gz > Am I missing something? The github macro is to be called that way: $(call github,user,package,version) See the manual, section 18.25.4 How to add a package from GitHub; https://nightly.buildroot.org/manual.html#github-download-url so for babeld: $(call github,jech,babeld,babeld-$(BABELD_VERSION)) See also the myriads of existing calls in the tree: git grep call\ github, Regards, Yann E. MORIN.
Hello Yann, On Sat, Aug 31, 2024 at 9:17 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Dario, All, > > On 2024-08-31 20:36 +0200, Dario Binacchi spake thusly: > > On Sat, Aug 31, 2024 at 6:25 PM Thomas Petazzoni > > <thomas.petazzoni@bootlin.com> wrote: > > > On Sat, 31 Aug 2024 16:54:49 +0200 > > > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > [--SNIP--] > > > > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files > > > > +BABELD_SITE = $(call github,jech,babeld,refs/tags) > > > This looks odd. Isn't the version needed somewhere? > > It seemed strange to me as well. Indeed, I don't see other similar > > _SITE settings in Buildroot. > > But if I go to the GitHub URL, these are the tarball addresses: > > https://github.com/jech/babeld/archive/refs/tags/babeld-1.9.2.tar.gz > > ... > > https://github.com/jech/babeld/archive/refs/tags/babeld-1.13.1.tar.gz > > Am I missing something? > > The github macro is to be called that way: > $(call github,user,package,version) > > See the manual, section 18.25.4 How to add a package from GitHub; > https://nightly.buildroot.org/manual.html#github-download-url > > so for babeld: > $(call github,jech,babeld,babeld-$(BABELD_VERSION)) > > See also the myriads of existing calls in the tree: > git grep call\ github, Thank you for the explanations. Regards, Dario > > Regards, > Yann E. MORIN. > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash index 2e0513efa010..e725b1fe310c 100644 --- a/package/babeld/babeld.hash +++ b/package/babeld/babeld.hash @@ -1,3 +1,3 @@ # Locally computed -sha256 154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07 babeld-1.9.2.tar.gz +sha256 c8c8c3698afb00caa5a5c9bbbb0a22b56d79ad3f9775382915ba979ac88c4e8f babeld-1.9.2.tar.gz sha256 b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd LICENCE diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk index 785fa2bce9f1..67d66da24f17 100644 --- a/package/babeld/babeld.mk +++ b/package/babeld/babeld.mk @@ -5,7 +5,7 @@ ################################################################################ BABELD_VERSION = 1.9.2 -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files +BABELD_SITE = $(call github,jech,babeld,refs/tags) BABELD_LICENSE = MIT BABELD_LICENSE_FILES = LICENCE
As reported in [1], version 1.9.2 has been moved to another archive, and it is recommended to use https://github.com/jech/babeld as the official repository. It was also necessary to change the sha of the downloaded tar.gz. Fixes: - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 [1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- Changes v1 -> v2: - Don't bump to 1.10.0 but update the URL site. package/babeld/babeld.hash | 2 +- package/babeld/babeld.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)