| Message ID | 20250424062154.2999219-1-dario.binacchi@amarulasolutions.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
On Thu, 24 Apr 2025 08:21:30 +0200, Dario Binacchi wrote: > This version keeps the version v9 patches that can be merged and > removes the patches that will need to be modified in case Peng's > PR https://github.com/devicetree-org/dt-schema/pull/154 is accepted. > The idea is to speed up the merging of the patches in the series > that have already been reviewed and are not dependent on the > introduction of the assigned-clocks-sscs property, and postpone > the patches for spread spectrum to a future series once it becomes > clear what needs to be done. > > [...] Applied, thanks! [01/19] dt-bindings: clock: imx8mm: add VIDEO_PLL clocks commit: 20e5d201b5d8f830e702d7d183f6b1b246b78d8a [02/19] clk: imx8mm: rename video_pll1 to video_pll commit: 26a33196b5b68cf199b6c4283a254aa92d2aaf4b [03/19] dt-bindings: clock: imx8mp: add VIDEO_PLL clocks commit: 2d50415e2457c6f6621c2faa3b01b11150fb9c67 [04/19] clk: imx8mp: rename video_pll1 to video_pll commit: 21bb969f608cefd8d847cf6eb50a193d9f1fbb87 [05/19] dt-bindings: clock: imx8m-anatop: add oscillators and PLLs commit: 2ba124053687c933031a6dc5b2e16ceaca250934 [10/19] clk: imx: add hw API imx_anatop_get_clk_hw commit: 17e3c1a272d97e49b4f3fbfe1f1b889e120d2be8 [11/19] clk: imx: add support for i.MX8MM anatop clock driver commit: 3cbc38cf42ca42d2dc9a93c949e0381ff919df71 [12/19] clk: imx: add support for i.MX8MN anatop clock driver commit: 80badb1d7264e83b512475898e7459f464a009c9 [13/19] clk: imx: add support for i.MX8MP anatop clock driver commit: 4c82bbe8b5437c7f16b2891ce33210c0f1410597 [14/19] clk: imx8mp: rename ccm_base to base commit: 1a77907dbbecfbe5e6a1aec28afd49a1dc184b7a [16/19] dt-bindings: clock: imx8m-clock: add PLLs commit: 6a55647af3334f1d935ece67de4a838a864b53fc Best regards,
Hello Shawn, On Mon, May 5, 2025 at 9:52 AM Abel Vesa <abel.vesa@linaro.org> wrote: > > > On Thu, 24 Apr 2025 08:21:30 +0200, Dario Binacchi wrote: > > This version keeps the version v9 patches that can be merged and > > removes the patches that will need to be modified in case Peng's > > PR https://github.com/devicetree-org/dt-schema/pull/154 is accepted. > > The idea is to speed up the merging of the patches in the series > > that have already been reviewed and are not dependent on the > > introduction of the assigned-clocks-sscs property, and postpone > > the patches for spread spectrum to a future series once it becomes > > clear what needs to be done. > > > > [...] > > Applied, thanks! > > [01/19] dt-bindings: clock: imx8mm: add VIDEO_PLL clocks > commit: 20e5d201b5d8f830e702d7d183f6b1b246b78d8a > [02/19] clk: imx8mm: rename video_pll1 to video_pll > commit: 26a33196b5b68cf199b6c4283a254aa92d2aaf4b > [03/19] dt-bindings: clock: imx8mp: add VIDEO_PLL clocks > commit: 2d50415e2457c6f6621c2faa3b01b11150fb9c67 > [04/19] clk: imx8mp: rename video_pll1 to video_pll > commit: 21bb969f608cefd8d847cf6eb50a193d9f1fbb87 > [05/19] dt-bindings: clock: imx8m-anatop: add oscillators and PLLs > commit: 2ba124053687c933031a6dc5b2e16ceaca250934 > [10/19] clk: imx: add hw API imx_anatop_get_clk_hw > commit: 17e3c1a272d97e49b4f3fbfe1f1b889e120d2be8 > [11/19] clk: imx: add support for i.MX8MM anatop clock driver > commit: 3cbc38cf42ca42d2dc9a93c949e0381ff919df71 > [12/19] clk: imx: add support for i.MX8MN anatop clock driver > commit: 80badb1d7264e83b512475898e7459f464a009c9 > [13/19] clk: imx: add support for i.MX8MP anatop clock driver > commit: 4c82bbe8b5437c7f16b2891ce33210c0f1410597 > [14/19] clk: imx8mp: rename ccm_base to base > commit: 1a77907dbbecfbe5e6a1aec28afd49a1dc184b7a > [16/19] dt-bindings: clock: imx8m-clock: add PLLs > commit: 6a55647af3334f1d935ece67de4a838a864b53fc > Please check the remaining patches, as they are required for correctly building the ones merged by Abel. The kernel test robot has already reported build errors. Thanks and regards, Dario > Best regards, > -- > Abel Vesa <abel.vesa@linaro.org>
On Thu, May 08, 2025 at 10:32:10AM +0200, Dario Binacchi wrote: > Hello Shawn, > > On Mon, May 5, 2025 at 9:52 AM Abel Vesa <abel.vesa@linaro.org> wrote: > > > > > > On Thu, 24 Apr 2025 08:21:30 +0200, Dario Binacchi wrote: > > > This version keeps the version v9 patches that can be merged and > > > removes the patches that will need to be modified in case Peng's > > > PR https://github.com/devicetree-org/dt-schema/pull/154 is accepted. > > > The idea is to speed up the merging of the patches in the series > > > that have already been reviewed and are not dependent on the > > > introduction of the assigned-clocks-sscs property, and postpone > > > the patches for spread spectrum to a future series once it becomes > > > clear what needs to be done. > > > > > > [...] > > > > Applied, thanks! > > > > [01/19] dt-bindings: clock: imx8mm: add VIDEO_PLL clocks > > commit: 20e5d201b5d8f830e702d7d183f6b1b246b78d8a > > [02/19] clk: imx8mm: rename video_pll1 to video_pll > > commit: 26a33196b5b68cf199b6c4283a254aa92d2aaf4b > > [03/19] dt-bindings: clock: imx8mp: add VIDEO_PLL clocks > > commit: 2d50415e2457c6f6621c2faa3b01b11150fb9c67 > > [04/19] clk: imx8mp: rename video_pll1 to video_pll > > commit: 21bb969f608cefd8d847cf6eb50a193d9f1fbb87 > > [05/19] dt-bindings: clock: imx8m-anatop: add oscillators and PLLs > > commit: 2ba124053687c933031a6dc5b2e16ceaca250934 > > [10/19] clk: imx: add hw API imx_anatop_get_clk_hw > > commit: 17e3c1a272d97e49b4f3fbfe1f1b889e120d2be8 > > [11/19] clk: imx: add support for i.MX8MM anatop clock driver > > commit: 3cbc38cf42ca42d2dc9a93c949e0381ff919df71 > > [12/19] clk: imx: add support for i.MX8MN anatop clock driver > > commit: 80badb1d7264e83b512475898e7459f464a009c9 > > [13/19] clk: imx: add support for i.MX8MP anatop clock driver > > commit: 4c82bbe8b5437c7f16b2891ce33210c0f1410597 > > [14/19] clk: imx8mp: rename ccm_base to base > > commit: 1a77907dbbecfbe5e6a1aec28afd49a1dc184b7a > > [16/19] dt-bindings: clock: imx8m-clock: add PLLs > > commit: 6a55647af3334f1d935ece67de4a838a864b53fc > > > > Please check the remaining patches, as they are required for correctly > building the > ones merged by Abel. The kernel test robot has already reported build errors. I assume the remaining patches are DTS ones? If so, I do not see how clock drivers would require DTS change to build correctly. Do you have a pointer to the reported build errors? My understanding about the build dependency is the opposite, i.e. the DTS changes require clock defines merged by Abel to build? In that case, I suggest Abel pick up the whole series with my ack on DTS changes. Acked-by: Shawn Guo <shawnguo@kernel.org> Alternatively, I can pick up the remaining patches after clock changes land on mainline (the next -rc1). Shawn To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
On Fri, May 9, 2025 at 2:02 PM Shawn Guo <shawnguo2@yeah.net> wrote: > > On Thu, May 08, 2025 at 10:32:10AM +0200, Dario Binacchi wrote: > > Hello Shawn, > > > > On Mon, May 5, 2025 at 9:52 AM Abel Vesa <abel.vesa@linaro.org> wrote: > > > > > > > > > On Thu, 24 Apr 2025 08:21:30 +0200, Dario Binacchi wrote: > > > > This version keeps the version v9 patches that can be merged and > > > > removes the patches that will need to be modified in case Peng's > > > > PR https://github.com/devicetree-org/dt-schema/pull/154 is accepted. > > > > The idea is to speed up the merging of the patches in the series > > > > that have already been reviewed and are not dependent on the > > > > introduction of the assigned-clocks-sscs property, and postpone > > > > the patches for spread spectrum to a future series once it becomes > > > > clear what needs to be done. > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [01/19] dt-bindings: clock: imx8mm: add VIDEO_PLL clocks > > > commit: 20e5d201b5d8f830e702d7d183f6b1b246b78d8a > > > [02/19] clk: imx8mm: rename video_pll1 to video_pll > > > commit: 26a33196b5b68cf199b6c4283a254aa92d2aaf4b > > > [03/19] dt-bindings: clock: imx8mp: add VIDEO_PLL clocks > > > commit: 2d50415e2457c6f6621c2faa3b01b11150fb9c67 > > > [04/19] clk: imx8mp: rename video_pll1 to video_pll > > > commit: 21bb969f608cefd8d847cf6eb50a193d9f1fbb87 > > > [05/19] dt-bindings: clock: imx8m-anatop: add oscillators and PLLs > > > commit: 2ba124053687c933031a6dc5b2e16ceaca250934 > > > [10/19] clk: imx: add hw API imx_anatop_get_clk_hw > > > commit: 17e3c1a272d97e49b4f3fbfe1f1b889e120d2be8 > > > [11/19] clk: imx: add support for i.MX8MM anatop clock driver > > > commit: 3cbc38cf42ca42d2dc9a93c949e0381ff919df71 > > > [12/19] clk: imx: add support for i.MX8MN anatop clock driver > > > commit: 80badb1d7264e83b512475898e7459f464a009c9 > > > [13/19] clk: imx: add support for i.MX8MP anatop clock driver > > > commit: 4c82bbe8b5437c7f16b2891ce33210c0f1410597 > > > [14/19] clk: imx8mp: rename ccm_base to base > > > commit: 1a77907dbbecfbe5e6a1aec28afd49a1dc184b7a > > > [16/19] dt-bindings: clock: imx8m-clock: add PLLs > > > commit: 6a55647af3334f1d935ece67de4a838a864b53fc > > > > > > > Please check the remaining patches, as they are required for correctly > > building the > > ones merged by Abel. The kernel test robot has already reported build errors. > > I assume the remaining patches are DTS ones? Yes > If so, I do not see how > clock drivers would require DTS change to build correctly. Do you have > a pointer to the reported build errors? https://lore.kernel.org/oe-kbuild-all/202505090537.ss8RbFln-lkp@intel.com/ DTC compilation fails. I think it's because of the patch [16/19] dt-bindings: clock: imx8m-clock: add PLLs which was merged without the corresponding DTS changes. Thanks and regards, Dario > > My understanding about the build dependency is the opposite, i.e. the > DTS changes require clock defines merged by Abel to build? In that > case, I suggest Abel pick up the whole series with my ack on DTS changes. > > Acked-by: Shawn Guo <shawnguo@kernel.org> > > Alternatively, I can pick up the remaining patches after clock changes > land on mainline (the next -rc1). > > Shawn >
On 09/05/2025 14:43, Dario Binacchi wrote: >>> >>> Please check the remaining patches, as they are required for correctly >>> building the >>> ones merged by Abel. The kernel test robot has already reported build errors. >> >> I assume the remaining patches are DTS ones? > Yes >> If so, I do not see how >> clock drivers would require DTS change to build correctly. Do you have >> a pointer to the reported build errors? > > https://lore.kernel.org/oe-kbuild-all/202505090537.ss8RbFln-lkp@intel.com/ > > DTC compilation fails. I think it's because of the patch > [16/19] dt-bindings: clock: imx8m-clock: add PLLs > which was merged without the corresponding DTS changes. NAK, why did you create patchset forcing DTS to be put into the driver subsystem? It is even beyond ABI break. Best regards, Krzysztof To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
This version keeps the version v9 patches that can be merged and removes the patches that will need to be modified in case Peng's PR https://github.com/devicetree-org/dt-schema/pull/154 is accepted. The idea is to speed up the merging of the patches in the series that have already been reviewed and are not dependent on the introduction of the assigned-clocks-sscs property, and postpone the patches for spread spectrum to a future series once it becomes clear what needs to be done. Specifically, the patches: 01/18 dt-bindings: clock: imx8mm: add VIDEO_PLL clocks 02/18 clk: imx8mm: rename video_pll1 to video_pll 03/18 dt-bindings: clock: imx8mp: add VIDEO_PLL clocks 04/18 clk: imx8mp: rename video_pll1 to video_pll are a replica for i.MX8MM and i.MX8MP of the patch for i.MX8MM bedcf9d1dcf88 ("clk: imx: rename video_pll1 to video_pll"), which was merged some time ago. The patches are split into four because, during the review, Krzysztof asked me to separate the driver modifications from the dt-bindings changes. All the other patches in the series, from 5 to 18, are necessary for the implementation of the anatop driver for i.MX8M{M,N,P}. The review of this series has taken a long time, partly due to misunderstandings arising from incorrect design choices. As Peng stated in [1]: "In current design, CCM is taken as producer of CLK_IMX8M_VIDEO_PLL, not consumer." These patches fix this issue by ensuring that the PLLs are now produced by Anatop and consumed by CCM, aligning with the hardware logic. Finally, a clarification: I decided to keep the same title for the series despite having removed all the patches for spread spectrum support in order to maintain a clear connection with the previous versions. [1] https://patchwork.kernel.org/project/linux-clk/patch/20241106090549.3684963-2-dario.binacchi@amarulasolutions.com/ Changes in v12: - Add the patch 15/19: arm64: dts: imx8mp-aristainetos3a-som-v1: don't replicate clk properties to fix new warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' Changes in v11: - Fix conflict while rebasing on master for patches: 13/18 clk: imx: add support for i.MX8MP anatop clock driver 14/18 clk: imx8mp: rename ccm_base to base 15/18 dt-bindings: clock: imx8m-clock: add PLLs - Add 'Reviewed-by' tag of Peng Fan for patches: 11/18 clk: imx: add support for i.MX8MM anatop clock driver 13/18 clk: imx: add support for i.MX8MP anatop clock driver 14/18 clk: imx8mp: rename ccm_base to base Changes in v10: - Drop the v9 patches: 16/23 dt-bindings: clock: imx8m-clock: support spread spectrum clocking 17/23 clk: imx: pll14xx: support spread spectrum clock generation 17/23 clk: imx8mn: support spread spectrum clock generation 21/23 clk: imx8mp: support spread spectrum clock generation 23/23 clk: imx8mm: support spread spectrum clock generation Changes in v9: - Add 'Reviewed-by' tag of Peng Fan for imx8mn platform patches - Fix building warning raised by the kernel test robot for patch v8, 11/18 clk: imx: add support for i.MX8MN anatop clock driver - Add patches for imx8m{m,p} platforms: - 23/23 clk: imx8mm: support spread spectrum clock generation - 22/23 clk: imx: add support for i.MX8MM anatop clock driver - 21/23 clk: imx8mp: support spread spectrum clock generation - 20/23 clk: imx8mp: rename ccm_base to base - 19/23 clk: imx: add support for i.MX8MP anatop clock driver Changes in v8: - Drop the patches added in version 7: - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM Changes in v7: - Add and manage fsl,anatop property as phandle to the anatop node with the new patches: - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM Changes in v6: - Merge patches: 10/20 dt-bindings: clock: imx8mm: add binding definitions for anatop 11/20 dt-bindings: clock: imx8mn: add binding definitions for anatop 12/20 dt-bindings: clock: imx8mp: add binding definitions for anatop to 05/20 dt-bindings: clock: imx8m-anatop: define clocks/clock-names now renamed 05/18 dt-bindings: clock: imx8m-anatop: add oscillators and PLLs - Split the patch 15/20 dt-bindings-clock-imx8m-clock-support-spread-spectru.patch into 12/18 dt-bindings: clock: imx8m-clock: add PLLs 16/18 dt-bindings: clock: imx8m-clock: support spread spectrum clocking Changes in v5: - Fix compilation errors. - Separate driver code from dt-bindings Changes in v4: - Add dt-bindings for anatop - Add anatop driver - Drop fsl,ssc-clocks from spread spectrum dt-bindings Changes in v3: - Patches 1/8 has been added in version 3. The dt-bindings have been moved from fsl,imx8m-anatop.yaml to imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is indeed more or less a syscon, so it represents a memory area accessible by ccm (imx8m-clock.yaml) to setup the PLLs. - Patches {3,5}/8 have been added in version 3. - Patches {4,6,8}/8 use ccm device node instead of the anatop one. Changes in v2: - Add "allOf:" and place it after "required:" block, like in the example schema. - Move the properties definition to the top-level. - Drop unit types as requested by the "make dt_binding_check" command. Dario Binacchi (19): dt-bindings: clock: imx8mm: add VIDEO_PLL clocks clk: imx8mm: rename video_pll1 to video_pll dt-bindings: clock: imx8mp: add VIDEO_PLL clocks clk: imx8mp: rename video_pll1 to video_pll dt-bindings: clock: imx8m-anatop: add oscillators and PLLs arm64: dts: imx8mm: add anatop clocks arm64: dts: imx8mn: add anatop clocks arm64: dts: imx8mp: add anatop clocks arm64: dts: imx8mq: add anatop clocks clk: imx: add hw API imx_anatop_get_clk_hw clk: imx: add support for i.MX8MM anatop clock driver clk: imx: add support for i.MX8MN anatop clock driver clk: imx: add support for i.MX8MP anatop clock driver clk: imx8mp: rename ccm_base to base arm64: dts: imx8mp-aristainetos3a-som-v1: don't replicate clk properties dt-bindings: clock: imx8m-clock: add PLLs arm64: dts: imx8mm: add PLLs to clock controller module (CCM) arm64: dts: imx8mn: add PLLs to clock controller module (CCM) arm64: dts: imx8mp: add PLLs to clock controller module (CCM) .../bindings/clock/fsl,imx8m-anatop.yaml | 53 +- .../bindings/clock/imx8m-clock.yaml | 27 +- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 11 +- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 11 +- .../imx8mp-aristainetos3a-som-v1.dtsi | 4 - arch/arm64/boot/dts/freescale/imx8mp.dtsi | 11 +- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 + drivers/clk/imx/Makefile | 6 +- drivers/clk/imx/clk-imx8mm-anatop.c | 287 ++++++++ drivers/clk/imx/clk-imx8mm.c | 262 ++++--- drivers/clk/imx/clk-imx8mn-anatop.c | 283 ++++++++ drivers/clk/imx/clk-imx8mn.c | 183 +++-- drivers/clk/imx/clk-imx8mp-anatop.c | 306 ++++++++ drivers/clk/imx/clk-imx8mp.c | 672 +++++++++--------- drivers/clk/imx/clk.c | 15 + drivers/clk/imx/clk.h | 2 + include/dt-bindings/clock/imx8mm-clock.h | 76 +- include/dt-bindings/clock/imx8mn-clock.h | 64 ++ include/dt-bindings/clock/imx8mp-clock.h | 80 ++- 19 files changed, 1740 insertions(+), 615 deletions(-) create mode 100644 drivers/clk/imx/clk-imx8mm-anatop.c create mode 100644 drivers/clk/imx/clk-imx8mn-anatop.c create mode 100644 drivers/clk/imx/clk-imx8mp-anatop.c