| Message ID | 20220726210217.3368497-1-dario.binacchi@amarulasolutions.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
On 26.07.2022 23:02:08, Dario Binacchi wrote: > With this series I try to finish the task, started with the series [1], > of completely removing the dependency of the slcan driver from the > userspace slcand/slcan_attach applications. > > The series also contains patches that remove the legacy stuff (slcan_devs, > SLCAN_MAGIC, ...) and do some module cleanup. > > The series has been created on top of the patches: > > can: slcan: convert comments to network style comments > can: slcan: slcan_init() convert printk(LEVEL ...) to pr_level() > can: slcan: fix whitespace issues > can: slcan: convert comparison to NULL into !val > can: slcan: clean up if/else > can: slcan: use scnprintf() as a hardening measure > can: slcan: do not report txerr and rxerr during bus-off > can: slcan: do not sleep with a spin lock held > > applied to linux-next. > > [1] https://lore.kernel.org/all/20220628163137.413025-1-dario.binacchi@amarulasolutions.com/ > > Changes in v3: > - Update the commit message. > - Use 1 space in front of the =. > - Put the series as RFC again. No need to change the series to RFC again :) > - Pick up the patch "can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names". > - Add the patch "ethtool: add support to get/set CAN bit time register" > to the series. > - Add the patch "can: slcan: add support to set bit time register (btr)" > to the series. > - Replace the link https://marc.info/?l=linux-can&m=165806705927851&w=2 with > https://lore.kernel.org/all/507b5973-d673-4755-3b64-b41cb9a13b6f@hartkopp.net. > - Add the `Suggested-by' tag. Please post a v4 with both BTR patches dropped and add Max Staudt's Reviewed-by to patch 3. Marc
With this series I try to finish the task, started with the series [1], of completely removing the dependency of the slcan driver from the userspace slcand/slcan_attach applications. The series also contains patches that remove the legacy stuff (slcan_devs, SLCAN_MAGIC, ...) and do some module cleanup. The series has been created on top of the patches: can: slcan: convert comments to network style comments can: slcan: slcan_init() convert printk(LEVEL ...) to pr_level() can: slcan: fix whitespace issues can: slcan: convert comparison to NULL into !val can: slcan: clean up if/else can: slcan: use scnprintf() as a hardening measure can: slcan: do not report txerr and rxerr during bus-off can: slcan: do not sleep with a spin lock held applied to linux-next. [1] https://lore.kernel.org/all/20220628163137.413025-1-dario.binacchi@amarulasolutions.com/ Changes in v3: - Update the commit message. - Use 1 space in front of the =. - Put the series as RFC again. - Pick up the patch "can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names". - Add the patch "ethtool: add support to get/set CAN bit time register" to the series. - Add the patch "can: slcan: add support to set bit time register (btr)" to the series. - Replace the link https://marc.info/?l=linux-can&m=165806705927851&w=2 with https://lore.kernel.org/all/507b5973-d673-4755-3b64-b41cb9a13b6f@hartkopp.net. - Add the `Suggested-by' tag. Changes in v2: - Re-add headers that export at least one symbol used by the module. - Update the commit description. - Drop the old "slcan" name to use the standard canX interface naming. - Remove comment on listen-only command. - Update the commit subject and description. - Add the patch "MAINTAINERS: Add myself as maintainer of the SLCAN driver" to the series. Dario Binacchi (8): can: slcan: remove useless header inclusions can: slcan: remove legacy infrastructure can: slcan: change every `slc' occurrence in `slcan' can: slcan: use the generic can_change_mtu() can: slcan: add support for listen-only mode ethtool: add support to get/set CAN bit time register can: slcan: add support to set bit time register (btr) MAINTAINERS: Add maintainer for the slcan driver Vincent Mailhol (1): can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names MAINTAINERS | 6 + drivers/net/can/slcan/slcan-core.c | 515 +++++++++----------------- drivers/net/can/slcan/slcan-ethtool.c | 13 + drivers/net/can/slcan/slcan.h | 1 + include/uapi/linux/ethtool.h | 1 + net/ethtool/common.c | 1 + net/ethtool/ioctl.c | 1 + 7 files changed, 204 insertions(+), 334 deletions(-)