[v2,1/3] sifive: fu540: Add sample SD gpt partition layout

Message ID 20200420133735.23599-1-jagan@amarulasolutions.com
State New
Headers show
Series
  • [v2,1/3] sifive: fu540: Add sample SD gpt partition layout
Related show

Commit Message

Jagan Teki April 20, 2020, 1:37 p.m. UTC
This is a sample GPT partition layout for SD card,
right now three important partitions are added to
make the system bootable.

partition layout:

Part    Start LBA       End LBA         Name
        Attributes
        Type GUID
        Partition GUID
  1     0x00000022      0x00000821      "loader1"
        attrs:  0x0000000000000000
        type:   5b193300-fc78-40cd-8002-e86c45580b47
        guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
  2     0x00000822      0x00002821      "loader2"
        attrs:  0x0000000000000000
        type:   2e54b353-1271-4842-806f-e436d6af6985
        guid:   f54eba28-d8de-4852-978d-1a673777e2ae
  3     0x00002822      0x00020821      "rootfs"
        attrs:  0x0000000000000004
        type:   0fc63daf-8483-4772-8e79-3d69d8477de4
        type:   linux
        guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93

Note:
- loader1 would be fsbl or spl
- loader2 would be U-Boot or U-Boot proper

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- update the partition table

Note: On top of https://patchwork.ozlabs.org/cover/1263480/

 board/sifive/fu540/Kconfig     |  2 ++
 include/configs/sifive-fu540.h | 13 +++++++++++++
 2 files changed, 15 insertions(+)

Comments

Pragnesh Patel April 29, 2020, 1:53 p.m. UTC | #1
Hi Jagan,

>-----Original Message-----
>From: Jagan Teki <jagan@amarulasolutions.com>
>Sent: 20 April 2020 19:08
>To: Pragnesh Patel <pragnesh.patel@sifive.com>; rick@andestech.com; u-
>boot@lists.denx.de
>Cc: bmeng.cn@gmail.com; Sagar Kadam <sagar.kadam@sifive.com>; Paul
>Walmsley <paul.walmsley@sifive.com>; Troy Benjegerdes
><troy.benjegerdes@sifive.com>; palmerdabbelt@google.com;
>anup.patel@wdc.com; atish.patra@wdc.com; linux-
>amarula@amarulasolutions.com; Jagan Teki <jagan@amarulasolutions.com>
>Subject: [PATCH v2 1/3] sifive: fu540: Add sample SD gpt partition layout
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>This is a sample GPT partition layout for SD card, right now three important
>partitions are added to make the system bootable.
>
>partition layout:
>
>Part    Start LBA       End LBA         Name
>        Attributes
>        Type GUID
>        Partition GUID
>  1     0x00000022      0x00000821      "loader1"
>        attrs:  0x0000000000000000
>        type:   5b193300-fc78-40cd-8002-e86c45580b47
>        guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
>  2     0x00000822      0x00002821      "loader2"
>        attrs:  0x0000000000000000
>        type:   2e54b353-1271-4842-806f-e436d6af6985
>        guid:   f54eba28-d8de-4852-978d-1a673777e2ae
>  3     0x00002822      0x00020821      "rootfs"
>        attrs:  0x0000000000000004
>        type:   0fc63daf-8483-4772-8e79-3d69d8477de4
>        type:   linux
>        guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93
>
>Note:
>- loader1 would be fsbl or spl
>- loader2 would be U-Boot or U-Boot proper
>
>Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>---
>Changes for v2:
>- update the partition table
>
>Note: On top of https://patchwork.ozlabs.org/cover/1263480/
>
> board/sifive/fu540/Kconfig     |  2 ++
> include/configs/sifive-fu540.h | 13 +++++++++++++
> 2 files changed, 15 insertions(+)
>
>diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig index
>5c67aab96a..43d01bab8d 100644
>--- a/board/sifive/fu540/Kconfig
>+++ b/board/sifive/fu540/Kconfig
>@@ -32,6 +32,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>        imply CMD_EXT4
>        imply CMD_FAT
>        imply CMD_FS_GENERIC
>+       imply CMD_GPT
>+       imply PARTITION_TYPE_GUID
>        imply CMD_NET
>        imply CMD_PING
>        imply CLK_SIFIVE
>diff --git a/include/configs/sifive-fu540.h b/include/configs/sifive-fu540.h
>index ef3ae9b650..72c841eb9b 100644
>--- a/include/configs/sifive-fu540.h
>+++ b/include/configs/sifive-fu540.h
>@@ -47,6 +47,15 @@
>
> #include <config_distro_bootcmd.h>
>
>+#define TYPE_GUID_LOADER1      "5B193300-FC78-40CD-8002-
>E86C45580B47"
>+#define TYPE_GUID_LOADER2      "2E54B353-1271-4842-806F-
>E436D6AF6985"
>+#define TYPE_GUID_SYSTEM       "0FC63DAF-8483-4772-8E79-
>3D69D8477DE4"
>+
>+#define PARTS_DEFAULT \
>+       "name=loader1,start=17K,size=1M,type=${type_guid_gpt_loader1};" \
>+       "name=loader2,size=4MB,type=${type_guid_gpt_loader2};" \
>+       "name=system,size=-,bootable,type=${type_guid_gpt_system};"
>+
> #define CONFIG_EXTRA_ENV_SETTINGS \
>        "fdt_high=0xffffffffffffffff\0" \
>        "initrd_high=0xffffffffffffffff\0" \ @@ -55,6 +64,10 @@
>        "scriptaddr=0x88100000\0" \
>        "pxefile_addr_r=0x88200000\0" \
>        "ramdisk_addr_r=0x88300000\0" \
>+       "type_guid_gpt_loader1=" TYPE_GUID_LOADER1 "\0" \
>+       "type_guid_gpt_loader2=" TYPE_GUID_LOADER2 "\0" \
>+       "type_guid_gpt_system=" TYPE_GUID_SYSTEM "\0" \
>+       "partitions=" PARTS_DEFAULT "\0" \

Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com>

>        BOOTENV
>
> #define CONFIG_PREBOOT \
>--
>2.17.1
Bin Meng April 29, 2020, 1:54 p.m. UTC | #2
On Mon, Apr 20, 2020 at 9:37 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> This is a sample GPT partition layout for SD card,
> right now three important partitions are added to
> make the system bootable.
>
> partition layout:
>
> Part    Start LBA       End LBA         Name
>         Attributes
>         Type GUID
>         Partition GUID
>   1     0x00000022      0x00000821      "loader1"
>         attrs:  0x0000000000000000
>         type:   5b193300-fc78-40cd-8002-e86c45580b47
>         guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
>   2     0x00000822      0x00002821      "loader2"
>         attrs:  0x0000000000000000
>         type:   2e54b353-1271-4842-806f-e436d6af6985
>         guid:   f54eba28-d8de-4852-978d-1a673777e2ae
>   3     0x00002822      0x00020821      "rootfs"
>         attrs:  0x0000000000000004
>         type:   0fc63daf-8483-4772-8e79-3d69d8477de4
>         type:   linux
>         guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93
>
> Note:
> - loader1 would be fsbl or spl
> - loader2 would be U-Boot or U-Boot proper
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - update the partition table
>
> Note: On top of https://patchwork.ozlabs.org/cover/1263480/
>
>  board/sifive/fu540/Kconfig     |  2 ++
>  include/configs/sifive-fu540.h | 13 +++++++++++++
>  2 files changed, 15 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Patch

diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig
index 5c67aab96a..43d01bab8d 100644
--- a/board/sifive/fu540/Kconfig
+++ b/board/sifive/fu540/Kconfig
@@ -32,6 +32,8 @@  config BOARD_SPECIFIC_OPTIONS # dummy
 	imply CMD_EXT4
 	imply CMD_FAT
 	imply CMD_FS_GENERIC
+	imply CMD_GPT
+	imply PARTITION_TYPE_GUID
 	imply CMD_NET
 	imply CMD_PING
 	imply CLK_SIFIVE
diff --git a/include/configs/sifive-fu540.h b/include/configs/sifive-fu540.h
index ef3ae9b650..72c841eb9b 100644
--- a/include/configs/sifive-fu540.h
+++ b/include/configs/sifive-fu540.h
@@ -47,6 +47,15 @@ 
 
 #include <config_distro_bootcmd.h>
 
+#define TYPE_GUID_LOADER1	"5B193300-FC78-40CD-8002-E86C45580B47"
+#define TYPE_GUID_LOADER2	"2E54B353-1271-4842-806F-E436D6AF6985"
+#define TYPE_GUID_SYSTEM	"0FC63DAF-8483-4772-8E79-3D69D8477DE4"
+
+#define PARTS_DEFAULT \
+	"name=loader1,start=17K,size=1M,type=${type_guid_gpt_loader1};" \
+	"name=loader2,size=4MB,type=${type_guid_gpt_loader2};" \
+	"name=system,size=-,bootable,type=${type_guid_gpt_system};"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
@@ -55,6 +64,10 @@ 
 	"scriptaddr=0x88100000\0" \
 	"pxefile_addr_r=0x88200000\0" \
 	"ramdisk_addr_r=0x88300000\0" \
+	"type_guid_gpt_loader1=" TYPE_GUID_LOADER1 "\0" \
+	"type_guid_gpt_loader2=" TYPE_GUID_LOADER2 "\0" \
+	"type_guid_gpt_system=" TYPE_GUID_SYSTEM "\0" \
+	"partitions=" PARTS_DEFAULT "\0" \
 	BOOTENV
 
 #define CONFIG_PREBOOT \