Message ID | 20220607094752.1029295-3-dario.binacchi@amarulasolutions.com |
---|---|
State | New |
Headers | show
Return-Path: <linux-amarula+bncBCQ4XFG47UFRBXV57SKAMGQEDWXMQOI@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E7D2C3F08A for <linux-amarula@patchwork.amarulasolutions.com>; Tue, 7 Jun 2022 11:48:14 +0200 (CEST) Received: by mail-wr1-f71.google.com with SMTP id v4-20020adfebc4000000b002102c69be5esf3691661wrn.13 for <linux-amarula@patchwork.amarulasolutions.com>; Tue, 07 Jun 2022 02:48:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1654595294; cv=pass; d=google.com; s=arc-20160816; b=xnZijO+ep4YJrrrewHuWeN6CymIgtOIX6ZrAYXr7Dlzn5zPe1iuC3zReZhlKYyJ1/f yCPIk8VS9RGMFkHKSCOPeAKOr2KSsjJnFc4nXfYEwcOkiR2OGXzBbTx+/PfHgmaJe66T fG5rrLYAAgggbnTcPkQt5gAfGi3sZXDdyWoGdYbflG6bm5jUZarYMu6zzqgDnJYVGefl YKKNFQbyzpOyVsidC0V3i0+4YTwRIEW7NOfp6LC6wnYy7l5nXmGMCBliCuuWAMoVXLGm WNfwVc4+0VSMkmRE1LqD9HQXPbYLu6/V6/Pzp3rLZGpnfp0W/VfkZUt5H+9LxOo46OEf ESLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=bjM6n5NUa9GCkY3tUTiK80yagFMtam1vcXQHsdwWxKE=; b=BxVyxRNzmRjjVsBBFzKGTkr0xnEtEf9ZYwavRLiMVpW8ybQkor7w0RQn1eGQVS7dku RT9thFuPiJltsMPHMPi7TcaRPcezBjsFB1XUhuL35w6yOYqLa1ySxzx+dwDoBhgq8cUJ whYeUuJk63NGZ4q19H/3BpFCzeJhb0BT6/p6IWse5jIkdRKtNsFBg5Gh3k22OwY4mhlz JoQYeIGdmlHygdESQZXJPgBbPGtIo7p4FKzZhS0hE/wPebtcthp5cZ7HH5280Pnfoa4Y p+XPNohwQwQIgOMZ/rx1jsDf2JC4XptSZoRNb0WFDOTWmAPc4iqYZl3SfIAsbA73dGmH B2CQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aSj7vDU7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=bjM6n5NUa9GCkY3tUTiK80yagFMtam1vcXQHsdwWxKE=; b=EaJTmEOfcGuUd9RchaZgL3jyDxvXX53oAxm0CNaqHB/RvbuzzndKD43ilJncZ2koLk WqqyVj7T+MizOGlHLzPq5Zsl2wwybi4g/sEZJ4652a21lr6hjFfDiBq8NSKbow1qPvI8 HFtauNX/or7mG1Br2DW/TH4XhizXDL4/bi5lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=bjM6n5NUa9GCkY3tUTiK80yagFMtam1vcXQHsdwWxKE=; b=pw1RqmtkFAbff5Bk0Z5RDhhVMeYpxV610VhH2Hw8i8rDiNrpT0b6bmVOv5DTQkSQB1 R9JaugbpiENSj3AtHTprjaJhLQMe7NU8XiDSO7rRxCip5gAk8j9TyXCbYbcRwd+bxQh2 Gvgb8R+dovx8GfXOAxXBm7BOI1o1s3ohZIKmC8lJ1A8h9wU4C5GyL8CedY0vuig6/HKR 1rcKPIog2PXWoij3ZBkLDefrsHdfzjPdhsU+4NqH2oFX8ZW38MJiSVQwWLt92V5fQG9B MJww+z1fW3JpRgDS/Bhiw4Q/Ogzo8rJLOyhhOVbfGrNkVMGuoIa6QiL9MabE5jQiM8kk h6XQ== X-Gm-Message-State: AOAM532d+XiYHgVzDz9hwC/gv72x96Gscf8rEBxTm8ZSut16h3QpzEHO 5kUc1Sfwnkdp4DJP0Ax+FQ2Eof9s X-Google-Smtp-Source: ABdhPJwbbOGDE5AvhqN7XTITwu9YDR046O+n/uifZaX8IA97IIv6cR6Vju5gbmwYu1D2VdsbPohrng== X-Received: by 2002:a5d:47a1:0:b0:218:423a:de8f with SMTP id 1-20020a5d47a1000000b00218423ade8fmr8445612wrb.420.1654595294544; Tue, 07 Jun 2022 02:48:14 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a5d:59ab:0:b0:214:1ae1:5d70 with SMTP id p11-20020a5d59ab000000b002141ae15d70ls4149112wrr.2.gmail; Tue, 07 Jun 2022 02:48:13 -0700 (PDT) X-Received: by 2002:a5d:6dd1:0:b0:210:7a1:cda0 with SMTP id d17-20020a5d6dd1000000b0021007a1cda0mr26649259wrz.570.1654595293455; Tue, 07 Jun 2022 02:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654595293; cv=none; d=google.com; s=arc-20160816; b=qsHjrejCq8lDIewjKjOrCMN0Oh/87vtKWj8fB/Oy/OzEoxsFQ7QRW1wvpS6rAySjYx vkQVklS4bjQ7Zv5+YgqPlH2AizNp0IODEA1YLuCtGxCe2vBkWh2xIaRYeW+kSBp48Jjo BCJHvT3UBc6m0rnCdUcEQfniuJxp6a9cb49soOkt9VPsHqBktFChOOZxOdlLnZ8tzNWC pax++griW5eBcUShkOVePKbrYO1wAd/p0xNYzGXlsyEOcR5+aFhPeGnTjA6+BKmj3vRP EOkSDYRtMFVtzp6CxDMlYWnSEmN3GjvzNeeEBXmLRyfvN5CmlY54U2ri4puwaoNjQZj3 eYEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tNUOqb45O/Ilv1mJP0lwEr7O4bll5ez6OZhdGeCnOYk=; b=q7meAI6PgdQL9laHx87kcpoyiPbw1kxxsYSEV7LuwT9qyOTxNAGAdpSHIlD8hERKq+ bYqDukICzQVo5iEE76xZbGk3MCIYHjNtxN9AE/6quitRuVmNRzMiyeltZNT00xLNFoup kPUT3rP2f+5RuX9hhOyfOgaFWBysQNWsYZPslS8sGeAZxS1yo8FhgvQlGSUMjgudxiTW cN2fgawRgjjuZZej082CJaNF5qFFTrr34/dAi2Eis1lpg1QjK6QgFAV+T+Fw5pB2czfX 6Eq5BIVu4+dNm80z0mLjs5autIYyOZ2xLxr/sPXqy2SuOvrDcyB9HvGb/4oKBt0U2lhO wDCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aSj7vDU7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id j4-20020adff544000000b00217fa88a7besor3264316wrp.62.2022.06.07.02.48.13 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Tue, 07 Jun 2022 02:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6000:1acc:b0:20f:e35e:450 with SMTP id i12-20020a0560001acc00b0020fe35e0450mr25899806wry.531.1654595293242; Tue, 07 Jun 2022 02:48:13 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (mob-5-90-137-51.net.vodafone.it. [5.90.137.51]) by smtp.gmail.com with ESMTPSA id o4-20020a05600c510400b0039748be12dbsm23200547wms.47.2022.06.07.02.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 02:48:12 -0700 (PDT) From: Dario Binacchi <dario.binacchi@amarulasolutions.com> To: linux-kernel@vger.kernel.org Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>, michael@amarulasolutions.com, Dario Binacchi <dario.binacchi@amarulasolutions.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Paolo Abeni <pabeni@redhat.com>, Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [RFC PATCH 02/13] can: slcan: use netdev helpers to print out messages Date: Tue, 7 Jun 2022 11:47:41 +0200 Message-Id: <20220607094752.1029295-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com> References: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aSj7vDU7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
Series |
|
Related |
show
|
diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b37d35c2a23a..6162a9c21672 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&sl->lock); if (!netif_running(dev)) { spin_unlock(&sl->lock); - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name); + netdev_warn(dev, "xmit: iface is down\n"); goto out; } if (sl->tty == NULL) { @@ -776,8 +776,7 @@ static void __exit slcan_exit(void) sl = netdev_priv(dev); if (sl->tty) { - printk(KERN_ERR "%s: tty discipline still running\n", - dev->name); + netdev_err(dev, "tty discipline still running\n"); } unregister_netdev(dev);
Replace printk() calls with corresponding netdev helpers. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- drivers/net/can/slcan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)