[6/7] media: ov5693: rename ov5693_check_hwcfg into ov5693_get_hwcfg
diff mbox series

Message ID 20220615152254.794909-7-tommaso.merciai@amarulasolutions.com
State New
Headers show
Series
  • media: ov5693: cleanup code and add dts support
Related show

Commit Message

Tommaso Merciai June 15, 2022, 3:22 p.m. UTC 
Function ov5693_check_hwcfg don't only check the hw configuration but
also get the hw configuration. Is better better to rename this into ov5693_get_hwcfg

Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
 drivers/media/i2c/ov5693.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dario Binacchi June 15, 2022, 4:10 p.m. UTC | #1 
On Wed, Jun 15, 2022 at 5:23 PM Tommaso Merciai
<tommaso.merciai@amarulasolutions.com> wrote:
>
> Function ov5693_check_hwcfg don't only check the hw configuration but
> also get the hw configuration. Is better better to rename this into ov5693_get_hwcfg
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
>  drivers/media/i2c/ov5693.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index d5a934ace597..273caef467fe 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -1339,7 +1339,7 @@ static int ov5693_get_regulators(struct ov5693_device *ov5693)
>                                        ov5693->supplies);
>  }
>
> -static int ov5693_check_hwcfg(struct ov5693_device *ov5693)
> +static int ov5693_get_hwcfg(struct ov5693_device *ov5693)
>  {
>         struct fwnode_handle *fwnode = dev_fwnode(ov5693->dev);
>         struct v4l2_fwnode_endpoint bus_cfg = {
> @@ -1431,7 +1431,7 @@ static int ov5693_probe(struct i2c_client *client)
>         ov5693->client = client;
>         ov5693->dev = &client->dev;
>
> -       ret = ov5693_check_hwcfg(ov5693);
> +       ret = ov5693_get_hwcfg(ov5693);
>         if (ret)
>                 return ret;
>
> --
> 2.25.1
>

Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Patch
diff mbox series 

diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
index d5a934ace597..273caef467fe 100644
--- a/drivers/media/i2c/ov5693.c
+++ b/drivers/media/i2c/ov5693.c
@@ -1339,7 +1339,7 @@  static int ov5693_get_regulators(struct ov5693_device *ov5693)
 				       ov5693->supplies);
 }
 
-static int ov5693_check_hwcfg(struct ov5693_device *ov5693)
+static int ov5693_get_hwcfg(struct ov5693_device *ov5693)
 {
 	struct fwnode_handle *fwnode = dev_fwnode(ov5693->dev);
 	struct v4l2_fwnode_endpoint bus_cfg = {
@@ -1431,7 +1431,7 @@  static int ov5693_probe(struct i2c_client *client)
 	ov5693->client = client;
 	ov5693->dev = &client->dev;
 
-	ret = ov5693_check_hwcfg(ov5693);
+	ret = ov5693_get_hwcfg(ov5693);
 	if (ret)
 		return ret;