| Message ID | 20220716170007.2020037-5-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <linux-amarula+bncBCQ4XFG47UFRBI65ZOLAMGQED7IBSGY@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 4D8023F046 for <linux-amarula@patchwork.amarulasolutions.com>; Sat, 16 Jul 2022 19:00:19 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id s17-20020a056402521100b0043ade613038sf5413571edd.17 for <linux-amarula@patchwork.amarulasolutions.com>; Sat, 16 Jul 2022 10:00:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657990819; cv=pass; d=google.com; s=arc-20160816; b=tWnAQFK51Fy7otogddARf/JuSt59G7QJ+WsL21PWWyq3TsNA26i8hWf8dULZFz2XWy XKuIa9xzAPtZp2Kgm0PG/0N7EMPsy8kg3OyTuhzczNMKrSg0n7Rvc77QJ4VeaeR9UXbg 8ftbuljvay1z4VskbTW4sELG1/STaJlax2xVW/5pKwjaHYSoMTmG+HRrqDqo1tJI7jMn uRFjapRUWLxDExGenBZlVIVcS0py92N8hw2qLxmFPA8e55sCY/mkxOvb5nSCeB0gVWbl miV9/543DGzkiQll1pAoM8C0ozNdR3Z6TKW/eOl/Vg1KxYV9GtVD7INByW2yk4QggsxI U1EQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=zFfEfnS/aKJzx5JFPouMms1a7V/eYWKEC0HqCoqSteI=; b=OLLD0aSUlxg52GvjBXM3jbd43sdMLteQ5OxynPx1KKxZ/HrazNtBRpL0ysttrfsSos QRwdBrsVim38PpQisPtrwaaylNiqPGOngb1SLw/VzxBtSWqSv47UWGQRb0pL+WEO/aBJ HRJXi4EpmlR32TsRmX3f+NUgetzvlOmjr+v4bGQdnW1umFuIsjTYC34GyDA+7d6l8ygY u42Qt9ZbcIqG++3a/EXoluDTAsmDyv5uuqRbi7YAAxpiRitFT7COFg9tHPD+i2Jx2bvL XQvGThOkWDCAGOk1DA6+h6uis+oMQta3ej3+1rt+9H+9TRiF3iF4sIz4S+Hxl1ZxMeV9 kz4g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mGoolG7f; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=zFfEfnS/aKJzx5JFPouMms1a7V/eYWKEC0HqCoqSteI=; b=lqXvGMgFpGUlEdKCDRTvSOWiy4qBdt/mRP/6RdrS2Fi9rbxD1DwSx9DMt6h1NmGM+B v3mski5662ZHFf9KiV1mjymRRxzvuU2g8lK2M1DTTDzqJglPzdv7XWP3WF6mF98DqlD8 yZCfvf1WSJOUycC2HvDpMCVj+vZXerxnsZGkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=zFfEfnS/aKJzx5JFPouMms1a7V/eYWKEC0HqCoqSteI=; b=HCUsr9C4wmPbgj5QdxS+tGGoQVL1m3frgj2R5y4bSjubkMKXe89j56AKiopWXjcQBI SL0psg517VL+Jx1a8RYviWojji7yT22AhLTVn6nuNKi8HSAilpQdHFggtFsDFWaNoZFF HDdooSUH1WypPCG+v4+x51kIlLemxwXPoQvIIactFxRDb6dEZOP3U8bVnpcP3ej08vzt 4nc7l/tmwP+0N8FQ8QMXwLVfONJpZoWzcNdBCe+77ceM8iLiCeCsJfqB8KSA4w3nCt/h mUv6AJMcWrGG5b21ObV6b7unwGfPbZQ3ITlIrL0lpzwIfkkykgbBrE9D5EMXNWwulNlv xECg== X-Gm-Message-State: AJIora+lwdqM9whPNx1jNS/5egoLo9x61bwNUVLpA4MN733NfMAzJXvp jlj1c5qHUsaSZJNLHY+Yf6ttphJx X-Google-Smtp-Source: AGRyM1ssVxXcgMccjZ1Zsl1y7c5JO4Jygud5qQC/a+HifdpBGR1MwBceYtAQdHppoIb767C0CJpNuA== X-Received: by 2002:a05:6402:212:b0:43b:5419:f89b with SMTP id t18-20020a056402021200b0043b5419f89bmr4202209edv.9.1657990819155; Sat, 16 Jul 2022 10:00:19 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:907:98c7:b0:726:2c39:8546 with SMTP id kd7-20020a17090798c700b007262c398546ls18317ejc.8.-pod-prod-gmail; Sat, 16 Jul 2022 10:00:18 -0700 (PDT) X-Received: by 2002:a17:906:4482:b0:70a:19e3:d18a with SMTP id y2-20020a170906448200b0070a19e3d18amr19182434ejo.510.1657990817941; Sat, 16 Jul 2022 10:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657990817; cv=none; d=google.com; s=arc-20160816; b=JJVDfTi1ISDpdg2kmiwg2b1wyy49F8+jhHmblNklrBIuHS78A0Xb4gKhkBUoWBNLmT wkN8ALMImuicaLYeVd8MGY4al7GJAHkpbhyK9lUvAAM9SFbR4EAJYI37Y8wBPWSemmvX iisWtLWQOegKzeRIzIaOu1vphBMQBceT/FdpUw4ITnT01E7qqBVKtAlp5nXkw0c9Zs3K d5yCCvmt0qr8Tx9S5qPJSLuL73zXRICEpkLrfbRw+xYjNfAqQb5yBuFQl8vLdkNkENUJ VDFTf6Ne+RGbcFTRDuObd5dUBff/AxxGkRdLATWBGYWgbzbVCa0PFxuJBvG7zBsHodkH t1ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=fHx3+JjARcVqLchAq3IBsPDCyyKS9HCXdr7RVf+WDMo=; b=0j6XwzKEQjENyv8hbveN9fVTC37I+E7p1Heh4vrjccQFh8ptwio3f/koPc+gl+sIcP ZNMYniWTUbC4sweNh+qsWQ1dCoCbUc0+Ztizpzc/AZf5q7hL9hhhyvt9E7hCY4TsU/5a 2m2SVB2oL+ygQ8J7+r9dUMETsEEPgo8QXrxVHtNlNUZ+h1jtVZVn2CehG4+wEEzJg/vZ FKFXJfBUtcFT+6zSUI9inWHH7feKyFOeKZbgbQoY0x2zRklRX9E1mGXtg+3l2WYUx/Hl T50yRvlA2rvpWm37VI19rth4Xfjti95WTY4zUWc5w51klTbeCF/w73sw1hPSGOxIUL1L SPkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mGoolG7f; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ty6-20020a170907c70600b0070afac782cesor2551365ejc.5.2022.07.16.10.00.17 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Sat, 16 Jul 2022 10:00:17 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:7294:b0:72b:1ae:9c47 with SMTP id dt20-20020a170907729400b0072b01ae9c47mr18608911ejc.253.1657990817736; Sat, 16 Jul 2022 10:00:17 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id g3-20020a170906538300b0072b14836087sm3363135ejo.103.2022.07.16.10.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 10:00:17 -0700 (PDT) From: Dario Binacchi <dario.binacchi@amarulasolutions.com> To: linux-kernel@vger.kernel.org Cc: Jeroen Hofstee <jhofstee@victronenergy.com>, michael@amarulasolutions.com, Amarula patchwork <linux-amarula@amarulasolutions.com>, Dario Binacchi <dario.binacchi@amarulasolutions.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jakub Kicinski <kuba@kernel.org>, Jiri Slaby <jirislaby@kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Paolo Abeni <pabeni@redhat.com>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [RFC PATCH 4/5] can: slcan: use the generic can_change_mtu() Date: Sat, 16 Jul 2022 19:00:06 +0200 Message-Id: <20220716170007.2020037-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220716170007.2020037-1-dario.binacchi@amarulasolutions.com> References: <20220716170007.2020037-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mGoolG7f; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
|
| Related |
show
|
diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 093d232c13dd..7a1540507ecd 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -727,16 +727,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops = { .ndo_open = slcan_netdev_open, .ndo_stop = slcan_netdev_close, .ndo_start_xmit = slcan_netdev_xmit, - .ndo_change_mtu = slcan_netdev_change_mtu, + .ndo_change_mtu = can_change_mtu, }; /******************************************
It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)