| Message ID | 20220728070254.267974-6-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <linux-amarula+bncBCQ4XFG47UFRBL7JRCLQMGQEPQ4FEVY@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id C20CE3F013 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 28 Jul 2022 09:03:11 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id g15-20020a056402424f00b0043bff7a68dbsf547292edb.10 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 28 Jul 2022 00:03:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658991791; cv=pass; d=google.com; s=arc-20160816; b=vtsZ9T0KrZjeW9bs85toizQNXtP8j74dO3KZPwYyHOshkdsp2RW+DmCbpuckfvfkY7 o+3r3I7AFHJCrA+TkygBILit18DtEnwu1gnIY7yXn9L5YWUlrNHR45FgEJs/DG16DSym VxaCQxdl8o5qBARJSbH86pzcTa94joieETdF3YWfEPOgYhsOF176MAqfkmv1LF7n4t7T 0hRhvPVrTjXUzxsE6oDMgDqijUC3A/9uZeNLQxyUCVwXii9bQrIKJERpN13I79DKl+mb d6WSRe2HRhlTzMJQJFOQIiZ/wEDVbjp+N9SoFTFq2SGqVYr9wIOhfwqjh0KHN5RanVw1 Kpcw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=dFdb06VZCuWHvIOKJPwhd1ruGc7GT0RTyPL3NI0kd38=; b=MeQBn9Ja+SuNShzACrP9/+rPDTjMm9quHcv/8FigTy1HaH7SgAvGCiSv2O8bmeTvdH NCQtWlD1bqLKA6tvZjVVnnBwMA2V0+bWbAgrJI6m3F+4ffpKEhXJ72WGNVfV00foHKia STIGL+h9n7Q0NNWrQzMsUvQjiEsEmNVeJN7E8Qu9eSfnQ2TasgV6c4k66Fhjx9Je2ehr cRpJb7VbRwgm39eltLqPtsZGx99HGL2UuUyMuwFOGXLO6RmdBp5sizRG7TxpKW3gcx06 BQFqVQGW4t7wRkedbHM9qWg2LoG4J55ABrXi9P+W5+dlPjQjD7vTD+gygsWUX+nAuYxD 80Uw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NixWIxUe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=dFdb06VZCuWHvIOKJPwhd1ruGc7GT0RTyPL3NI0kd38=; b=GAY/nsPN0E2XYak/jV6JDkxikA9UqWi9uE1dbPbQOndvdTd+iZmBBATopXyC2vXvjp 8mZyEs/EKP+Fsn8d90Lb/joff44uyaaPoLDJikytzgo1o0xwcnT2mVOb1yDnlIk9ScBT QfThqV4QoB8JAJozF32cwcupT5HtFyhU/w3Zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=dFdb06VZCuWHvIOKJPwhd1ruGc7GT0RTyPL3NI0kd38=; b=pxqIFpjNCcISmnf4Lg7uNsVupZRz/NtppOy9iG2yfJ534fRTGZzhz1kooL6pmOdy61 h3eOqNvg2kRXeKc2fNfOYP6Zom2lAk01wnxdi8UgDsVB3J8/2VZ6vdbj1m5IZ+s3GGrg uNjRzvr+Kdc4PlLD39rLueYaPBbjYfsr6C0yjvKAIjFGB4IAeeaA5+1YmqBDjTbCNtDj 3vcghAZUEpn1QQYyjoi/Bce5+ChnpScpWPlHGaCV+RXpwiKX6JB3CqRlSSLHu0zpxWmx Fi/PhnwPOPPDN2b/xSenhhfpgzqTFV5IpfYlE6CTD4FYjg4wCMzMFIvBND4SCKj3jlX0 kF/g== X-Gm-Message-State: AJIora8QhjMZVvhmTwpO3P4E+wbApN1vRxAbStwpSsrzcjh1WV77+i0Z gKQXAGl+8oIsMU9hF3fahrER2B0s X-Google-Smtp-Source: AGRyM1t78D0tD47VkLUKSDpz6G4jvvigUYdNla2Pf9ehPjRz0P60pytbdQm7xTkK+HsRjsqOK9Gx2w== X-Received: by 2002:a05:6402:168a:b0:43c:c76b:25ec with SMTP id a10-20020a056402168a00b0043cc76b25ecmr4643910edv.47.1658991791568; Thu, 28 Jul 2022 00:03:11 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:1e90:b0:43a:77a6:b0d with SMTP id f16-20020a0564021e9000b0043a77a60b0dls944234edf.3.-pod-prod-gmail; Thu, 28 Jul 2022 00:03:10 -0700 (PDT) X-Received: by 2002:aa7:cb58:0:b0:43c:e7ac:3567 with SMTP id w24-20020aa7cb58000000b0043ce7ac3567mr1585175edt.110.1658991790385; Thu, 28 Jul 2022 00:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658991790; cv=none; d=google.com; s=arc-20160816; b=wWXpAOFreQTG873drVAYnswn0jZ3yGjrU+dVn7WonTYkz4bKhDWD9woNxuOfbQmhiB 1/4cZ3+KPaj+ILetz3ka5xqi9iXdMcnwPnmKyFeT0R7kCkz1MD9GrsX5xr5BwV9aptSU cFu1z+BflGeCGCiNhdLUMLfWOpqWcigESSVqPv6CO89ysa7dvNZudS58x2qzczpuZ5vg Z3EiZroWoKZ+ewaUSYmWrxxfRwCmTLV/lJYGaMKh9J8QCqUTQcCoQtNGAXA6TFKe4Khr Zwku/ULjHq4whoaRmhUPvlokFsHY/m457ImZEajxKoiNTByWCayd+/9+qsHhuiqRprf2 cGlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=aNGQLRTnPxlP6A96D7J1ivHff8xTlXOO4TAacZru318=; b=hFoIfsPakVtCphgRL+T2g5CnD/93udPWExaXxQaY0GuH+o+uqSrJh2ZJYZW+T9rHo4 WXpmc8RrD4g4vWIQEAfWsAvuJdf/xXsIVyADmjABGuuXLWKn0kXGCmbjvpWn5rHzhdM1 bwJpzmqn6+L2R5gt6fHXQTUuCQTXhv4DLFUsjhbxtQ/e9ZzGDlgrTbVGpEWechH13Bba TWT6HorsUtZ2TsXf0LcPBZL2NH7Xp74A0/jatpws13bOlZoJOFmNLWI9U4b5oUX8chjp O1yAVSYfW3150+0AfSJJ5e5SoBnbTPIEn9anvt0GJrp1oYfbQPnk1o4lINkBkt1eWvPx bgOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NixWIxUe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 3-20020a508e03000000b0043b2d1d8528sor115500edw.34.2022.07.28.00.03.10 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Thu, 28 Jul 2022 00:03:10 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:2b88:b0:43a:6c58:6c64 with SMTP id fj8-20020a0564022b8800b0043a6c586c64mr27065401edb.348.1658991790073; Thu, 28 Jul 2022 00:03:10 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-31-31-9.retail.telecomitalia.it. [79.31.31.9]) by smtp.gmail.com with ESMTPSA id r18-20020aa7d152000000b0042de3d661d2sm154742edo.1.2022.07.28.00.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:03:09 -0700 (PDT) From: Dario Binacchi <dario.binacchi@amarulasolutions.com> To: linux-kernel@vger.kernel.org Cc: linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>, Jeroen Hofstee <jhofstee@victronenergy.com>, michael@amarulasolutions.com, Amarula patchwork <linux-amarula@amarulasolutions.com>, Oliver Hartkopp <socketcan@hartkopp.net>, Dario Binacchi <dario.binacchi@amarulasolutions.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Wolfgang Grandegger <wg@grandegger.com>, netdev@vger.kernel.org Subject: [PATCH v4 5/7] can: slcan: use the generic can_change_mtu() Date: Thu, 28 Jul 2022 09:02:52 +0200 Message-Id: <20220728070254.267974-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220728070254.267974-1-dario.binacchi@amarulasolutions.com> References: <20220728070254.267974-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NixWIxUe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
|
| Related |
show
|
diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index bd8e84ded051..d12d98426f37 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -742,16 +742,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops = { .ndo_open = slcan_netdev_open, .ndo_stop = slcan_netdev_close, .ndo_start_xmit = slcan_netdev_xmit, - .ndo_change_mtu = slcan_netdev_change_mtu, + .ndo_change_mtu = can_change_mtu, }; /******************************************
It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v1) drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)