[RESEND,v2] arm: dts: imx8mn-u-boot: fix DDR3 only support

Message ID 20230128160405.62324-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • [RESEND,v2] arm: dts: imx8mn-u-boot: fix DDR3 only support
Related show

Commit Message

Dario Binacchi Jan. 28, 2023, 4:04 p.m. UTC
In case the CONFIG_IMX8M_LPDDR4 and CONFIG_IMX8M_DDR4 options are both
disabled (i. e. BSH boards), binmain fails because DDR4 bin files are
missing.

Fixes: 93c4c0e4dd1e75 ("arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

---

Changes in v2:
- Fix typos in the commit message (DD3 --> DDR3, DD4 --> DDR4)

 arch/arm/dts/imx8mn-u-boot.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Fabio Estevam Jan. 28, 2023, 5:51 p.m. UTC | #1
On Sat, Jan 28, 2023 at 1:04 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> In case the CONFIG_IMX8M_LPDDR4 and CONFIG_IMX8M_DDR4 options are both
> disabled (i. e. BSH boards), binmain fails because DDR4 bin files are
> missing.
>
> Fixes: 93c4c0e4dd1e75 ("arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

Reviewed-by: Fabio Estevam <festevam@denx.de>

Patch

diff --git a/arch/arm/dts/imx8mn-u-boot.dtsi b/arch/arm/dts/imx8mn-u-boot.dtsi
index 95f45ad2522d..ec53390afb30 100644
--- a/arch/arm/dts/imx8mn-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-u-boot.dtsi
@@ -105,10 +105,11 @@ 
 			align-end = <4>;
 		};
 
+#if defined(CONFIG_IMX8M_LPDDR4) || defined(CONFIG_IMX8M_DDR4)
 		ddr-2d-imem-fw {
 #ifdef CONFIG_IMX8M_LPDDR4
 			filename = "lpddr4_pmu_train_2d_imem.bin";
-#elif CONFIG_IMX8M_DDR4
+#else
 			filename = "ddr4_imem_2d.bin";
 #endif
 			type = "blob-ext";
@@ -118,12 +119,13 @@ 
 		ddr-2d-dmem-fw {
 #ifdef CONFIG_IMX8M_LPDDR4
 			filename = "lpddr4_pmu_train_2d_dmem.bin";
-#elif CONFIG_IMX8M_DDR4
+#else
 			filename = "ddr4_dmem_2d.bin";
 #endif
 			type = "blob-ext";
 			align-end = <4>;
 		};
+#endif
 	};
 
 	spl {