[RFC] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
diff mbox series

Message ID 20230904180635.923506-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • [RFC] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
Related show

Commit Message

Dario Binacchi Sept. 4, 2023, 6:06 p.m. UTC 
In the board schematic, the power supply for the SD card is the same 3.3
volts used to power the LCD panel and other peripherals. By generalizing
the name of the voltage regulator, it simplifies the device tree and makes
it more readable.

Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

Comments

Alexandre TORGUE Sept. 14, 2023, 8:56 a.m. UTC | #1 
On 9/4/23 20:06, Dario Binacchi wrote:
> In the board schematic, the power supply for the SD card is the same 3.3
> volts used to power the LCD panel and other peripherals. By generalizing
> the name of the voltage regulator, it simplifies the device tree and makes
> it more readable.
> 

It makes sens as it is the same discret regulator (no pmic involved).

regards
Alex

> Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>   arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
>   1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
> index cbbd521bf010..8a4f8ddd083d 100644
> --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
> +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
> @@ -69,16 +69,9 @@ aliases {
>   		serial0 = &usart3;
>   	};
>   
> -	mmc_vcard: mmc_vcard {
> +	vcc_3v3: vcc-3v3 {
>   		compatible = "regulator-fixed";
> -		regulator-name = "mmc_vcard";
> -		regulator-min-microvolt = <3300000>;
> -		regulator-max-microvolt = <3300000>;
> -	};
> -
> -	vdd_dsi: vdd-dsi {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vdd_dsi";
> +		regulator-name = "vcc_3v3";
>   		regulator-min-microvolt = <3300000>;
>   		regulator-max-microvolt = <3300000>;
>   	};
> @@ -164,7 +157,7 @@ panel@0 {
>   		compatible = "orisetech,otm8009a";
>   		reg = <0>; /* dsi virtual channel (0..3) */
>   		reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
> -		power-supply = <&vdd_dsi>;
> +		power-supply = <&vcc_3v3>;
>   		status = "okay";
>   
>   		port {
> @@ -219,7 +212,7 @@ timer@2 {
>   
>   &sdio {
>   	status = "okay";
> -	vmmc-supply = <&mmc_vcard>;
> +	vmmc-supply = <&vcc_3v3>;
>   	cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
>   	broken-cd;
>   	pinctrl-names = "default", "opendrain";
Dario Binacchi Oct. 23, 2023, 11 a.m. UTC | #2 
Hello Alexandre,

On Thu, Sep 14, 2023 at 10:57 AM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> On 9/4/23 20:06, Dario Binacchi wrote:
> > In the board schematic, the power supply for the SD card is the same 3.3
> > volts used to power the LCD panel and other peripherals. By generalizing
> > the name of the voltage regulator, it simplifies the device tree and makes
> > it more readable.
> >
>
> It makes sens as it is the same discret regulator (no pmic involved).
>

I don't see it applied to linux-stm32/next. Is something missing?

Thanks and regards,
Dario

> regards
> Alex
>
> > Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> >   arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
> >   1 file changed, 4 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
> > index cbbd521bf010..8a4f8ddd083d 100644
> > --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
> > +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
> > @@ -69,16 +69,9 @@ aliases {
> >               serial0 = &usart3;
> >       };
> >
> > -     mmc_vcard: mmc_vcard {
> > +     vcc_3v3: vcc-3v3 {
> >               compatible = "regulator-fixed";
> > -             regulator-name = "mmc_vcard";
> > -             regulator-min-microvolt = <3300000>;
> > -             regulator-max-microvolt = <3300000>;
> > -     };
> > -
> > -     vdd_dsi: vdd-dsi {
> > -             compatible = "regulator-fixed";
> > -             regulator-name = "vdd_dsi";
> > +             regulator-name = "vcc_3v3";
> >               regulator-min-microvolt = <3300000>;
> >               regulator-max-microvolt = <3300000>;
> >       };
> > @@ -164,7 +157,7 @@ panel@0 {
> >               compatible = "orisetech,otm8009a";
> >               reg = <0>; /* dsi virtual channel (0..3) */
> >               reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
> > -             power-supply = <&vdd_dsi>;
> > +             power-supply = <&vcc_3v3>;
> >               status = "okay";
> >
> >               port {
> > @@ -219,7 +212,7 @@ timer@2 {
> >
> >   &sdio {
> >       status = "okay";
> > -     vmmc-supply = <&mmc_vcard>;
> > +     vmmc-supply = <&vcc_3v3>;
> >       cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
> >       broken-cd;
> >       pinctrl-names = "default", "opendrain";
>
Alexandre TORGUE Nov. 8, 2023, 1:38 p.m. UTC | #3 
Hi Dario



On 10/23/23 13:00, Dario Binacchi wrote:
> Hello Alexandre,
> 
> On Thu, Sep 14, 2023 at 10:57 AM Alexandre TORGUE
> <alexandre.torgue@foss.st.com> wrote:
>>
>> On 9/4/23 20:06, Dario Binacchi wrote:
>>> In the board schematic, the power supply for the SD card is the same 3.3
>>> volts used to power the LCD panel and other peripherals. By generalizing
>>> the name of the voltage regulator, it simplifies the device tree and makes
>>> it more readable.
>>>
>>
>> It makes sens as it is the same discret regulator (no pmic involved).
>>
> 
> I don't see it applied to linux-stm32/next. Is something missing?

ok, It is because the [RFC..] has been kept. Please resend by dropping it.

Cheers
Alex

> 
> Thanks and regards,
> Dario
> 
>> regards
>> Alex
>>
>>> Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
>>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>>
>>> ---
>>>
>>>    arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
>>>    1 file changed, 4 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> index cbbd521bf010..8a4f8ddd083d 100644
>>> --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> @@ -69,16 +69,9 @@ aliases {
>>>                serial0 = &usart3;
>>>        };
>>>
>>> -     mmc_vcard: mmc_vcard {
>>> +     vcc_3v3: vcc-3v3 {
>>>                compatible = "regulator-fixed";
>>> -             regulator-name = "mmc_vcard";
>>> -             regulator-min-microvolt = <3300000>;
>>> -             regulator-max-microvolt = <3300000>;
>>> -     };
>>> -
>>> -     vdd_dsi: vdd-dsi {
>>> -             compatible = "regulator-fixed";
>>> -             regulator-name = "vdd_dsi";
>>> +             regulator-name = "vcc_3v3";
>>>                regulator-min-microvolt = <3300000>;
>>>                regulator-max-microvolt = <3300000>;
>>>        };
>>> @@ -164,7 +157,7 @@ panel@0 {
>>>                compatible = "orisetech,otm8009a";
>>>                reg = <0>; /* dsi virtual channel (0..3) */
>>>                reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
>>> -             power-supply = <&vdd_dsi>;
>>> +             power-supply = <&vcc_3v3>;
>>>                status = "okay";
>>>
>>>                port {
>>> @@ -219,7 +212,7 @@ timer@2 {
>>>
>>>    &sdio {
>>>        status = "okay";
>>> -     vmmc-supply = <&mmc_vcard>;
>>> +     vmmc-supply = <&vcc_3v3>;
>>>        cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
>>>        broken-cd;
>>>        pinctrl-names = "default", "opendrain";
>>
> 
>

Patch
diff mbox series 

diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
index cbbd521bf010..8a4f8ddd083d 100644
--- a/arch/arm/boot/dts/st/stm32f469-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
@@ -69,16 +69,9 @@  aliases {
 		serial0 = &usart3;
 	};
 
-	mmc_vcard: mmc_vcard {
+	vcc_3v3: vcc-3v3 {
 		compatible = "regulator-fixed";
-		regulator-name = "mmc_vcard";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-	};
-
-	vdd_dsi: vdd-dsi {
-		compatible = "regulator-fixed";
-		regulator-name = "vdd_dsi";
+		regulator-name = "vcc_3v3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 	};
@@ -164,7 +157,7 @@  panel@0 {
 		compatible = "orisetech,otm8009a";
 		reg = <0>; /* dsi virtual channel (0..3) */
 		reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
-		power-supply = <&vdd_dsi>;
+		power-supply = <&vcc_3v3>;
 		status = "okay";
 
 		port {
@@ -219,7 +212,7 @@  timer@2 {
 
 &sdio {
 	status = "okay";
-	vmmc-supply = <&mmc_vcard>;
+	vmmc-supply = <&vcc_3v3>;
 	cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
 	broken-cd;
 	pinctrl-names = "default", "opendrain";