[1/1] package/ipmitool: add hash for enterprise-numbers.txt

Message ID 20240823063318.961358-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • [1/1] package/ipmitool: add hash for enterprise-numbers.txt
Related show

Commit Message

Dario Binacchi Aug. 23, 2024, 6:33 a.m. UTC
Fixes:
- http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/ipmitool/ipmitool.hash | 1 +
 1 file changed, 1 insertion(+)

Comments

'Krzysztof Kozlowski' via Amarula Linux Aug. 23, 2024, 7:55 a.m. UTC | #1
On Fri, 23 Aug 2024 08:33:18 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> Fixes:
> - http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

I believe it is not possible to do that
because https://www.iana.org/assignments/enterprise-numbers.txt is not a
"versioned" URL, and that file is regularly updated, so this hash will
become broken at some point in the future, causing breakage.

So basically, we need one of the two following options:

(Best)      Find a URL for enterprise-numbers.txt that is versioned, so
            that we know what we fetch is stable

(Less Best) Add something like BR_REALLY_NO_CHECK_HASH_FOR that
            continues to disable the hash check even when
            BR2_DOWNLOAD_FORCE_CHECK_HASHES is enabled

Best regards,

Thomas

Patch

diff --git a/package/ipmitool/ipmitool.hash b/package/ipmitool/ipmitool.hash
index c3b298e3ba5d..c303afa0f5e7 100644
--- a/package/ipmitool/ipmitool.hash
+++ b/package/ipmitool/ipmitool.hash
@@ -1,3 +1,4 @@ 
 # Locally computed:
 sha256  48b010e7bcdf93e4e4b6e43c53c7f60aa6873d574cbd45a8d86fa7aaeebaff9c  ipmitool-1_8_19.tar.gz
 sha256  b7e2382a8be43b5f6cb092f2d2bda163bf1a1938be9300f821a845cbcd535f56  COPYING
+sha256  ba2da37bd53a3c04df63c3e5dd1bed123e693ee37fdb9b834f61d2ff4df68a40  enterprise-numbers.txt