[v3,1/2] package/babeld: update URL site

3352 diff mbox series

As reported in [1], version 1.9.2 has been moved to another archive, and
it is recommended to use https://github.com/jech/babeld as the official
repository.

It was also necessary to change the sha of the downloaded tar.gz.

Fixes:
- http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9

[1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
Changes v2 -> v3:
  - Fix the way the github macro is called.

Changes v1 -> v2:
  - Don't bump to 1.10.0 but update the URL site.

 package/babeld/babeld.hash | 2 +-
 package/babeld/babeld.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Dario, All,

On 2024-09-01 08:36 +0200, Dario Binacchi spake thusly:
> As reported in [1], version 1.9.2 has been moved to another archive, and
> it is recommended to use https://github.com/jech/babeld as the official
> repository.
> 
> It was also necessary to change the sha of the downloaded tar.gz.

That is not going to be possible.

Indeed, we already have a tarball cached for babeld-1.9.2, and of course
it is the old one, so it has the old hash. Also, people will already
have a local archive of babeld, also with the old hash.

If we were to update the hash, then newer version of Buildroot could not
use the file cached on s.b.o, and people with a local cache will also
have an issue, especially those that do maintenance between various
branches, some with older Buildroots, other with newer ones.

In that situation, we need to find a way so that the new archive has a
different name. There are a few options:

  - use a git hash rather than a version
  - use a trick in the version string
  - change the download mechanism

The first option is not nice, because then we lose the possibility to
have follow releases from release-monitoring.org

The second option is also not very nice, because that also breaks
release-monitoring.org, but would otherwise look like:

    # When bumping the version, move the babeld- prefix into the github macro call
    BABELD_VERSION = babeld-1.9.2
    BABELD_SITE = $(call github,jech,babeld,$(BABELD_VERSION))

But since we are trying to move away from the github macro (long term
goal), I'd even suggest we directly switch to using the git download
method:

    BABELD_VERSION = 1.9.2
    BABELD_SITE = https://github.com/jech/babeld
    BABELD_SITE_METHOD = git

which would mean the archive filename would change:

    sha256 XX...XX babeld-1.9.2-git4.tar.gz

(yes, I know I suggested having the babeld- prefix in the github nacro
call, but I just forgot about the implications with the hash, sorry.)

Regards,
Yann E. MORIN.

> Fixes:
> - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9
> 
> [1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> Changes v2 -> v3:
>   - Fix the way the github macro is called.
> 
> Changes v1 -> v2:
>   - Don't bump to 1.10.0 but update the URL site.
> 
>  package/babeld/babeld.hash | 2 +-
>  package/babeld/babeld.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash
> index 2e0513efa010..e725b1fe310c 100644
> --- a/package/babeld/babeld.hash
> +++ b/package/babeld/babeld.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07  babeld-1.9.2.tar.gz
> +sha256  c8c8c3698afb00caa5a5c9bbbb0a22b56d79ad3f9775382915ba979ac88c4e8f  babeld-1.9.2.tar.gz
>  sha256  b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd  LICENCE
> diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk
> index 785fa2bce9f1..3f9a944ed063 100644
> --- a/package/babeld/babeld.mk
> +++ b/package/babeld/babeld.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  BABELD_VERSION = 1.9.2
> -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files
> +BABELD_SITE = $(call github,jech,babeld,babeld-$(BABELD_VERSION))
>  BABELD_LICENSE = MIT
>  BABELD_LICENSE_FILES = LICENCE
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Hi Yann,

On Mon, Sep 2, 2024 at 6:23 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Dario, All,
>
> On 2024-09-01 08:36 +0200, Dario Binacchi spake thusly:
> > As reported in [1], version 1.9.2 has been moved to another archive, and
> > it is recommended to use https://github.com/jech/babeld as the official
> > repository.
> >
> > It was also necessary to change the sha of the downloaded tar.gz.
>
> That is not going to be possible.
>
> Indeed, we already have a tarball cached for babeld-1.9.2, and of course
> it is the old one, so it has the old hash. Also, people will already
> have a local archive of babeld, also with the old hash.
>
> If we were to update the hash, then newer version of Buildroot could not
> use the file cached on s.b.o, and people with a local cache will also
> have an issue, especially those that do maintenance between various
> branches, some with older Buildroots, other with newer ones.
>
> In that situation, we need to find a way so that the new archive has a
> different name. There are a few options:
>
>   - use a git hash rather than a version
>   - use a trick in the version string
>   - change the download mechanism
>
> The first option is not nice, because then we lose the possibility to
> have follow releases from release-monitoring.org
>
> The second option is also not very nice, because that also breaks
> release-monitoring.org, but would otherwise look like:
>
>     # When bumping the version, move the babeld- prefix into the github macro call
>     BABELD_VERSION = babeld-1.9.2
>     BABELD_SITE = $(call github,jech,babeld,$(BABELD_VERSION))
>
> But since we are trying to move away from the github macro (long term
> goal), I'd even suggest we directly switch to using the git download
> method:
>
>     BABELD_VERSION = 1.9.2
>     BABELD_SITE = https://github.com/jech/babeld
>     BABELD_SITE_METHOD = git
>
> which would mean the archive filename would change:
>
>     sha256 XX...XX babeld-1.9.2-git4.tar.gz
>
> (yes, I know I suggested having the babeld- prefix in the github nacro
> call, but I just forgot about the implications with the hash, sorry.)

Don't worry.
Thanks again for the detailed explanation.
I will submit v3 ASAP.

Regards,
Dario

>
> Regards,
> Yann E. MORIN.
>
> > Fixes:
> > - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9
> >
> > [1] https://alioth-lists.debian.net/pipermail/babel-users/2024-August/004187.html
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> > Changes v2 -> v3:
> >   - Fix the way the github macro is called.
> >
> > Changes v1 -> v2:
> >   - Don't bump to 1.10.0 but update the URL site.
> >
> >  package/babeld/babeld.hash | 2 +-
> >  package/babeld/babeld.mk   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash
> > index 2e0513efa010..e725b1fe310c 100644
> > --- a/package/babeld/babeld.hash
> > +++ b/package/babeld/babeld.hash
> > @@ -1,3 +1,3 @@
> >  # Locally computed
> > -sha256  154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07  babeld-1.9.2.tar.gz
> > +sha256  c8c8c3698afb00caa5a5c9bbbb0a22b56d79ad3f9775382915ba979ac88c4e8f  babeld-1.9.2.tar.gz
> >  sha256  b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd  LICENCE
> > diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk
> > index 785fa2bce9f1..3f9a944ed063 100644
> > --- a/package/babeld/babeld.mk
> > +++ b/package/babeld/babeld.mk
> > @@ -5,7 +5,7 @@
> >  ################################################################################
> >
> >  BABELD_VERSION = 1.9.2
> > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files
> > +BABELD_SITE = $(call github,jech,babeld,babeld-$(BABELD_VERSION))
> >  BABELD_LICENSE = MIT
> >  BABELD_LICENSE_FILES = LICENCE
> >
> > --
> > 2.43.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

Dario, All,

On 2024-09-02 19:52 +0200, Dario Binacchi spake thusly:
> On Mon, Sep 2, 2024 at 6:23 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > But since we are trying to move away from the github macro (long term
> > goal), I'd even suggest we directly switch to using the git download
> > method:
> >     BABELD_VERSION = 1.9.2

Of course, here, we'd need to have: BABELD_VERSION = babeld-1.9.2

because that's what the tag is named.

This will also break the release-monitoring, but I am already working,
as part of the plan to migrate away from $(call github), on a way to be
able to specify a "download version" that is different from the "actual
version"...

In the meantime, we'll have to live with that limitation...

(and to be clear: I still suggest using the git download method, not the
github macro).

Regards,
Yann E. MORIN.