[1/1] package/armadillo: fix static build
diff mbox series

Message ID 20241212073449.449807-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • [1/1] package/armadillo: fix static build
Related show

Commit Message

Dario Binacchi Dec. 12, 2024, 7:34 a.m. UTC 
By default, the library is generated as shared. Therefore, if
BR2_STATIC_LIBS is selected, let's require the creation of a
static library.

Fixes:
- https://autobuild.buildroot.org/results/fdaf2028b97f60bc01d22d3caeb9a6432d92b598

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/armadillo/armadillo.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Julien Olivain Dec. 12, 2024, 9:50 p.m. UTC | #1 
On 12/12/2024 08:34, Dario Binacchi wrote:
> By default, the library is generated as shared. Therefore, if
> BR2_STATIC_LIBS is selected, let's require the creation of a
> static library.
> 
> Fixes:
> - 
> https://autobuild.buildroot.org/results/fdaf2028b97f60bc01d22d3caeb9a6432d92b598
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Applied to master, thanks.

> ---
>  package/armadillo/armadillo.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/armadillo/armadillo.mk 
> b/package/armadillo/armadillo.mk
> index e2d7c3968f2a..0d2e85464f6a 100644
> --- a/package/armadillo/armadillo.mk
> +++ b/package/armadillo/armadillo.mk
> @@ -30,4 +30,8 @@ ARMADILLO_CONF_OPTS += -DLAPACK_FOUND=ON
>  ARMADILLO_DEPENDENCIES += lapack
>  endif
> 
> +ifeq ($(BR2_STATIC_LIBS),y)
> +ARMADILLO_CONF_OPTS += -DSTATIC_LIB=ON
> +endif
> +
>  $(eval $(cmake-package))
> --
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.

Patch
diff mbox series 

diff --git a/package/armadillo/armadillo.mk b/package/armadillo/armadillo.mk
index e2d7c3968f2a..0d2e85464f6a 100644
--- a/package/armadillo/armadillo.mk
+++ b/package/armadillo/armadillo.mk
@@ -30,4 +30,8 @@  ARMADILLO_CONF_OPTS += -DLAPACK_FOUND=ON
 ARMADILLO_DEPENDENCIES += lapack
 endif
 
+ifeq ($(BR2_STATIC_LIBS),y)
+ARMADILLO_CONF_OPTS += -DSTATIC_LIB=ON
+endif
+
 $(eval $(cmake-package))