ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
diff mbox series

Message ID 20250301115116.2862353-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • ARM: dts: stm32: use IRQ_TYPE_EDGE_FALLING on stm32mp157c-dk2
Related show

Commit Message

Dario Binacchi March 1, 2025, 11:51 a.m. UTC 
Replace the number 2 with the appropriate numerical constant defined in
dt-bindings/interrupt-controller/irq.h.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Antonio Borneo March 1, 2025, 12:45 p.m. UTC | #1 
On Sat, 2025-03-01 at 12:51 +0100, Dario Binacchi wrote:
> Replace the number 2 with the appropriate numerical constant defined in
> dt-bindings/interrupt-controller/irq.h.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>  arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> index 5f9c0160a9c4..dcf17c493022 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> @@ -11,6 +11,7 @@
>  #include "stm32mp15-pinctrl.dtsi"
>  #include "stm32mp15xxac-pinctrl.dtsi"
>  #include "stm32mp15xx-dkx.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
>  
>  / {
>         model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> @@ -67,7 +68,7 @@ &i2c1 {
>         touchscreen@38 {
>                 compatible = "focaltech,ft6236";
>                 reg = <0x38>;
> -               interrupts = <2 2>;
> +               interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>                 interrupt-parent = <&gpiof>;
>                 touchscreen-size-x = <480>;
>                 touchscreen-size-y = <800>;

Thanks!

Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
Alexandre TORGUE March 10, 2025, 10:48 a.m. UTC | #2 
Hi Dario

On 3/1/25 12:51, Dario Binacchi wrote:
> Replace the number 2 with the appropriate numerical constant defined in
> dt-bindings/interrupt-controller/irq.h.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>   arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> index 5f9c0160a9c4..dcf17c493022 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> @@ -11,6 +11,7 @@
>   #include "stm32mp15-pinctrl.dtsi"
>   #include "stm32mp15xxac-pinctrl.dtsi"
>   #include "stm32mp15xx-dkx.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>

really needed ? as it comes also with 
dt-bindings/interrupt-controller/arm-gic.h

>   / {
>   	model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> @@ -67,7 +68,7 @@ &i2c1 {
>   	touchscreen@38 {
>   		compatible = "focaltech,ft6236";
>   		reg = <0x38>;
> -		interrupts = <2 2>;
> +		interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>   		interrupt-parent = <&gpiof>;
>   		touchscreen-size-x = <480>;
>   		touchscreen-size-y = <800>;

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
Dario Binacchi March 10, 2025, 12:24 p.m. UTC | #3 
Hi Alexandre,

On Mon, Mar 10, 2025 at 11:50 AM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> Hi Dario
>
> On 3/1/25 12:51, Dario Binacchi wrote:
> > Replace the number 2 with the appropriate numerical constant defined in
> > dt-bindings/interrupt-controller/irq.h.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> >   arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > index 5f9c0160a9c4..dcf17c493022 100644
> > --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
> > @@ -11,6 +11,7 @@
> >   #include "stm32mp15-pinctrl.dtsi"
> >   #include "stm32mp15xxac-pinctrl.dtsi"
> >   #include "stm32mp15xx-dkx.dtsi"
> > +#include <dt-bindings/interrupt-controller/irq.h>
>
> really needed ? as it comes also with
> dt-bindings/interrupt-controller/arm-gic.h

yes, you are right:
         stm32mp157c-dk2.dts
         --> stm32mp157.dtsi
               --> stm32mp153.dtsi
                     --> stm32mp151.dtsi
                           #include <dt-bindings/interrupt-controller/arm-gic.h>

I'll submit v2.

Thanks and regards
Dario
>
> >   / {
> >       model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
> > @@ -67,7 +68,7 @@ &i2c1 {
> >       touchscreen@38 {
> >               compatible = "focaltech,ft6236";
> >               reg = <0x38>;
> > -             interrupts = <2 2>;
> > +             interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> >               interrupt-parent = <&gpiof>;
> >               touchscreen-size-x = <480>;
> >               touchscreen-size-y = <800>;

Patch
diff mbox series 

diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
index 5f9c0160a9c4..dcf17c493022 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
@@ -11,6 +11,7 @@ 
 #include "stm32mp15-pinctrl.dtsi"
 #include "stm32mp15xxac-pinctrl.dtsi"
 #include "stm32mp15xx-dkx.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	model = "STMicroelectronics STM32MP157C-DK2 Discovery Board";
@@ -67,7 +68,7 @@  &i2c1 {
 	touchscreen@38 {
 		compatible = "focaltech,ft6236";
 		reg = <0x38>;
-		interrupts = <2 2>;
+		interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-parent = <&gpiof>;
 		touchscreen-size-x = <480>;
 		touchscreen-size-y = <800>;