| Message ID | 20251013201518.3832459-1-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On 13/10/2025 22:15, Dario Binacchi wrote: > Adding PKGLIBDIR to CFLAGS was necessary to fix the following error > raised during the compilation of the new version: > > execute.c: In function ‘set_environ’: > execute.c:107:48: error: ‘PKGLIBDIR’ undeclared (first use in this > function) > 107 | *ppch++ = setlocalenv("%s=%s", "PATH", PKGLIBDIR > ":/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"); > | ^~~~~~~~~ > execute.c:107:48: note: each undeclared identifier is reported only > once for each function it appears in > execute.c:107:57: error: expected ‘)’ before string constant > 107 | *ppch++ = setlocalenv("%s=%s", "PATH", PKGLIBDIR > ":/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"); > > This PKGLIBDIR define was added upstream in commit [1] in the Makefile > default CFLAGS, but since Buildroot redefines those it needs to be > added > back. > > Release notes since 0.8.41: > https://salsa.debian.org/debian/ifupdown/-/blob/master/debian/changelog#L1 > > [1] > https://salsa.debian.org/debian/ifupdown/-/commit/1eee7a3040eb7ba295c44beddbfb44abf342ca2c > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Applied to master, thanks. To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
diff --git a/package/ifupdown/ifupdown.hash b/package/ifupdown/ifupdown.hash index f5c2d2d34c4f..6412cf9d90a3 100644 --- a/package/ifupdown/ifupdown.hash +++ b/package/ifupdown/ifupdown.hash @@ -1,4 +1,4 @@ -# From http://snapshot.debian.org/archive/debian/20230222T205615Z/pool/main/i/ifupdown/ifupdown_0.8.41.dsc -sha256 222c5bef313a9e71d9be4b946c73c8606c98f9e0229153191d9c6d8fb9b3599c ifupdown_0.8.41.tar.xz +# From http://snapshot.debian.org/archive/debian/20240917T144520Z/pool/main/i/ifupdown/ifupdown_0.8.44.dsc +sha256 6121a19702e2e86b8f3aaac90d486ae8d557477f769718f3eb838945b697bcad ifupdown_0.8.44.tar.xz # Locally computed sha256 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670 COPYING diff --git a/package/ifupdown/ifupdown.mk b/package/ifupdown/ifupdown.mk index 14c36db0dbc6..395e46208294 100644 --- a/package/ifupdown/ifupdown.mk +++ b/package/ifupdown/ifupdown.mk @@ -4,16 +4,16 @@ # ################################################################################ -IFUPDOWN_VERSION = 0.8.41 +IFUPDOWN_VERSION = 0.8.44 IFUPDOWN_SOURCE = ifupdown_$(IFUPDOWN_VERSION).tar.xz -IFUPDOWN_SITE = http://snapshot.debian.org/archive/debian/20230222T205615Z/pool/main/i/ifupdown +IFUPDOWN_SITE = http://snapshot.debian.org/archive/debian/20240917T144520Z/pool/main/i/ifupdown IFUPDOWN_LICENSE = GPL-2.0+ IFUPDOWN_LICENSE_FILES = COPYING IFUPDOWN_CPE_ID_VENDOR = debian define IFUPDOWN_BUILD_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \ - CFLAGS="$(TARGET_CFLAGS) -std=gnu99 -D'IFUPDOWN_VERSION=\"$(IFUPDOWN_VERSION)\"'" \ + CFLAGS="$(TARGET_CFLAGS) -std=gnu99 -D'PKGLIBDIR=\"/lib/ifupdown\"' -D'IFUPDOWN_VERSION=\"$(IFUPDOWN_VERSION)\"'" \ ARCH=linux \ -C $(@D) endef
Adding PKGLIBDIR to CFLAGS was necessary to fix the following error raised during the compilation of the new version: execute.c: In function ‘set_environ’: execute.c:107:48: error: ‘PKGLIBDIR’ undeclared (first use in this function) 107 | *ppch++ = setlocalenv("%s=%s", "PATH", PKGLIBDIR ":/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"); | ^~~~~~~~~ execute.c:107:48: note: each undeclared identifier is reported only once for each function it appears in execute.c:107:57: error: expected ‘)’ before string constant 107 | *ppch++ = setlocalenv("%s=%s", "PATH", PKGLIBDIR ":/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"); This PKGLIBDIR define was added upstream in commit [1] in the Makefile default CFLAGS, but since Buildroot redefines those it needs to be added back. Release notes since 0.8.41: https://salsa.debian.org/debian/ifupdown/-/blob/master/debian/changelog#L1 [1] https://salsa.debian.org/debian/ifupdown/-/commit/1eee7a3040eb7ba295c44beddbfb44abf342ca2c Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- package/ifupdown/ifupdown.hash | 4 ++-- package/ifupdown/ifupdown.mk | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)