[2/3] dt-bindings: ili9806e: add Rocktech RK050HR345-CT106A display
diff mbox series

Message ID 20260106154446.2735701-3-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • drm/panel: ilitek-ili9806e: add Rocktech RK050HR345-CT106A support
Related show

Commit Message

Dario Binacchi Jan. 6, 2026, 3:43 p.m. UTC 
Document the Rocktech 5" 480x854 panel based on the Ilitek ILI9806E
controller.

This panel uses SPI for control and an RGB interface for display
data, so adjust the binding requirements accordingly.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 .../display/panel/ilitek,ili9806e.yaml        | 43 +++++++++++++++++--
 1 file changed, 40 insertions(+), 3 deletions(-)

Comments

'Krzysztof Kozlowski' via Amarula Linux Jan. 7, 2026, 8:09 a.m. UTC | #1 
On Tue, Jan 06, 2026 at 04:43:15PM +0100, Dario Binacchi wrote:
> @@ -29,12 +30,29 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - vdd-supply
> -  - vccio-supply
>    - reset-gpios
>    - backlight
>    - port
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - rocktech,rk050hr345-ct106a
> +then:
> +  $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +  properties:
> +    spi-max-frequency: true

This two lines are not needed.

> +
> +  required:
> +    - spi-max-frequency

How does it work without any supplies?

> +else:
> +  required:
> +    - vdd-supply
> +    - vccio-supply

Best regards,
Krzysztof

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.

Patch
diff mbox series 

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
index f80307579485..61d035419126 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Ilitek ILI9806E based MIPI-DSI panels
+title: Ilitek ILI9806E based panels
 
 maintainers:
   - Michael Walle <mwalle@kernel.org>
@@ -18,6 +18,7 @@  properties:
       - enum:
           - densitron,dmt028vghmcmi-1d
           - ortustech,com35h3p70ulc
+          - rocktech,rk050hr345-ct106a
       - const: ilitek,ili9806e
 
   reg:
@@ -29,12 +30,29 @@  properties:
 required:
   - compatible
   - reg
-  - vdd-supply
-  - vccio-supply
   - reset-gpios
   - backlight
   - port
 
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - rocktech,rk050hr345-ct106a
+then:
+  $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+  properties:
+    spi-max-frequency: true
+
+  required:
+    - spi-max-frequency
+else:
+  required:
+    - vdd-supply
+    - vccio-supply
+
 unevaluatedProperties: false
 
 examples:
@@ -60,5 +78,24 @@  examples:
             };
         };
     };
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
 
+        panel@0 {
+            compatible = "rocktech,rk050hr345-ct106a", "ilitek,ili9806e";
+            reg = <0>;
+            spi-max-frequency = <10000000>;
+            reset-gpios = <&gpiob 6 GPIO_ACTIVE_LOW>;
+            backlight = <&backlight>;
+            port {
+                panel_in_rgb: endpoint {
+                    remote-endpoint = <&ltdc_out_rgb>;
+                };
+            };
+        };
+    };
 ...