[2/3] package/armadillo: needs gcc >= 8
diff mbox series

Message ID 20260730200118.3547779-3-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • package/armadillo: bump to 15.4.2 and fix build failures
Related show

Commit Message

Dario Binacchi July 30, 2026, 8:01 p.m. UTC 
Upstream bumped the minimum required gcc version from 6.1 to 8.1 in
commit 84ec3ddf9fd3 ("bump minimum gcc version to 8.1"), so the build
now fails with "Compiler too old; need at least gcc 8.1" on older
toolchains.

There is no gcc 8.0.x release (the 8.x series starts at 8.1.0), so
BR2_TOOLCHAIN_GCC_AT_LEAST_8 is enough to express this dependency.

While at it, add the gcc version to the openblas-arch comment, which
only checked for C++ support and would therefore stay hidden on
toolchains that are too old.

Fixes: 597d5d10ec77 ("package/armadillo: bump to version 15.0.1")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/armadillo/Config.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Patch
diff mbox series 

diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
index 7a93343d41f8..7b66179fb829 100644
--- a/package/armadillo/Config.in
+++ b/package/armadillo/Config.in
@@ -1,19 +1,19 @@ 
-comment "armadillo needs a toolchain w/ C++"
+comment "armadillo needs a toolchain w/ C++, gcc >= 8"
 	depends on BR2_PACKAGE_OPENBLAS_ARCH_SUPPORTS
-	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
-comment "armadillo needs a toolchain w/ fortran, C++, gcc >= 4.9"
+comment "armadillo needs a toolchain w/ fortran, C++, gcc >= 8"
 	depends on !BR2_PACKAGE_OPENBLAS_ARCH_SUPPORTS # otherwise, see comment above
 	depends on BR2_PACKAGE_LAPACK_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_FORTRAN || !BR2_INSTALL_LIBSTDCPP
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
 config BR2_PACKAGE_ARMADILLO
 	bool "armadillo"
 	depends on BR2_PACKAGE_OPENBLAS_ARCH_SUPPORTS || \
 		(BR2_PACKAGE_LAPACK_ARCH_SUPPORTS && BR2_TOOLCHAIN_HAS_FORTRAN)
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # armadillo requires gcc >= 8.1
 	help
 	  Armadillo: An Open Source C++ Linear Algebra Library for
 	  Fast Prototyping and Computationally Intensive Experiments.