diff mbox series

ARM: dts: stm32: fix display pinmux for stm32f746-disco

Message ID 20230601170602.2845768-1-dario.binacchi@amarulasolutions.com
State New
Headers
Series ARM: dts: stm32: fix display pinmux for stm32f746-disco |

Commit Message

Dario Binacchi June 1, 2023, 5:06 p.m. UTC 
As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9  -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini June 1, 2023, 5:11 p.m. UTC | #1 
On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
> As reported by the datasheet (DocID027590 Rev 4) for PG12:
> - AF9  -> LCD_B4
> - AF14 -> LCD_B1
> 
> So replace AF14 with AF9 for PG12 in the dts.
> 
> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> index 19b5451db441..522cffb1ac9f 100644
> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> @@ -169,7 +169,7 @@
>  	ltdc_pins: ltdc@0 {
>  		pins {
>  			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
> -				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
> +				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
>  				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
>  				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
>  				 <STM32_PINMUX('I',14, AF14)>, /* CLK */

Why is this whole stanza in a -u-boot.dtsi file and not an upstream
file?
Dario Binacchi June 2, 2023, 10:29 a.m. UTC | #2 
On Thu, Jun 1, 2023 at 7:11 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
> > As reported by the datasheet (DocID027590 Rev 4) for PG12:
> > - AF9  -> LCD_B4
> > - AF14 -> LCD_B1
> >
> > So replace AF14 with AF9 for PG12 in the dts.
> >
> > Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> >  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > index 19b5451db441..522cffb1ac9f 100644
> > --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > @@ -169,7 +169,7 @@
> >       ltdc_pins: ltdc@0 {
> >               pins {
> >                       pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
> > -                              <STM32_PINMUX('G',12, AF14)>, /* B4 */
> > +                              <STM32_PINMUX('G',12, AF9)>,  /* B4 */
> >                                <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
> >                                <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
> >                                <STM32_PINMUX('I',14, AF14)>, /* CLK */
>
> Why is this whole stanza in a -u-boot.dtsi file and not an upstream
> file?

I just submitted a series to the linux kernel to add support for
display on stm32f746-disco.
https://lore.kernel.org/linux-arm-kernel/20230601170320.2845218-1-dario.binacchi@amarulasolutions.com/T/

Thanks and regards,
Dario
>
> --
> Tom
Patrice CHOTARD June 5, 2023, 12:20 p.m. UTC | #3 
Hi Tom

On 6/1/23 19:11, Tom Rini wrote:
> On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
>> As reported by the datasheet (DocID027590 Rev 4) for PG12:
>> - AF9  -> LCD_B4
>> - AF14 -> LCD_B1
>>
>> So replace AF14 with AF9 for PG12 in the dts.
>>
>> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>
>> ---
>>
>>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> index 19b5451db441..522cffb1ac9f 100644
>> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> @@ -169,7 +169,7 @@
>>  	ltdc_pins: ltdc@0 {
>>  		pins {
>>  			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
>> -				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
>> +				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
>>  				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
>>  				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
>>  				 <STM32_PINMUX('I',14, AF14)>, /* CLK */
> 
> Why is this whole stanza in a -u-boot.dtsi file and not an upstream
> file?
> 

LTDC entry has been put in stm32f746-disco-u-boot.dtsi by anticipation as described
in commit 01aabf97d1f0 ("ARM: dts: stm32: Migrate U-boot nodes to U-boot DT files for stm32f7")

So U-Boot DT will be synchronized with kernel one when Dario series will be available in kernel release.
The LTDC entry located in stm32f746-disco-u-boot.dtsi will be then removed.

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
index 19b5451db441..522cffb1ac9f 100644
--- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
+++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
@@ -169,7 +169,7 @@ 
 	ltdc_pins: ltdc@0 {
 		pins {
 			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
-				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
+				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
 				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
 				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
 				 <STM32_PINMUX('I',14, AF14)>, /* CLK */