diff mbox series

[1/1] package/libtirpc: add option for RPC Database support

Message ID 20251226174623.2006300-1-dario.binacchi@amarulasolutions.com
State New
Headers
Series [1/1] package/libtirpc: add option for RPC Database support |

Commit Message

Dario Binacchi Dec. 26, 2025, 5:46 p.m. UTC 
Commit 7cea8ad66aec ("Add conditional version script support") broke
backward compatibility for the RPC database interfaces, and indeed the
build of xinetd fails with the following errors:

buildroot/output/per-package/xinetd/host/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/14.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: confparse.o: in function `cnf_get':
buildroot/build/xinetd-2.3.15/xinetd/buildroot/build/xinetd-2.3.15/xinetd/confparse.c:990:(.text+0x34c): undefined reference to `endrpcent'
buildroot/output/per-package/xinetd/host/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/14.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: confparse.o: in function `check_entry':
buildroot/build/xinetd-2.3.15/xinetd/buildroot/build/xinetd-2.3.15/xinetd/confparse.c:752:(.text+0xeed): undefined reference to `getrpcbyname'
collect2: error: ld returned 1 exit status

Fixes: 3f3d6e43de9b ("package/libtirpc: bump to version 1.3.7")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/libtirpc/Config.in   | 6 ++++++
 package/libtirpc/libtirpc.mk | 8 ++++++++
 2 files changed, 14 insertions(+)

Comments

Giulio Benetti Dec. 26, 2025, 5:59 p.m. UTC | #1 
<html class="apple-mail-supports-explicit-dark-mode"><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hi Dario,<div><br></div><div>I’ve already sent a patch for this:</div><div><div style="display: block;" class=""><div style="-webkit-user-select: all; -webkit-user-drag: element; display: inline-block;" class="apple-rich-link" draggable="true" role="link" data-url="https://lore.kernel.org/buildroot/20251214170654.GD193459@pevik/"><a style="border-radius:10px;font-family:-apple-system, Helvetica, Arial, sans-serif;display:block;-webkit-user-select:none;width:228px;user-select:none;-webkit-user-modify:read-only;user-modify:read-only;overflow:hidden;text-decoration:none;" class="lp-rich-link" rel="nofollow" href="https://lore.kernel.org/buildroot/20251214170654.GD193459@pevik/" dir="ltr" role="button" draggable="false" width="228"><table style="table-layout:fixed;border-collapse:collapse;width:228px;background-color:#8B6045;font-family:-apple-system, Helvetica, Arial, sans-serif;" class="lp-rich-link-emailBaseTable" cellpadding="0" cellspacing="0" border="0" width="228"><tbody><tr><td vertical-align="center" align="center"><img style="width:228px;filter:brightness(0.97);height:228px;" width="228" height="228" draggable="false" class="lp-rich-link-mediaImage" alt="pensive.webp" src="cid:B9A10E04-247F-4EE3-A156-989C0FE233DD"></td></tr><tr><td vertical-align="center"><table bgcolor="#8B6045" cellpadding="0" cellspacing="0" width="228" style="table-layout:fixed;font-family:-apple-system, Helvetica, Arial, sans-serif;background-color:rgba(139, 96, 69, 1);-apple-color-filter:initial;" class="lp-rich-link-captionBar"><tbody><tr><td style="padding:8px 0px 8px 0px;" class="lp-rich-link-captionBar-textStackItem"><div style="max-width:100%;margin:0px 16px 0px 16px;overflow:hidden;" class="lp-rich-link-captionBar-textStack"><div style="word-wrap:break-word;font-weight:500;font-size:12px;overflow:hidden;text-overflow:ellipsis;text-align:left;" class="lp-rich-link-captionBar-textStack-topCaption-leading"><a rel="nofollow" href="https://lore.kernel.org/buildroot/20251214170654.GD193459@pevik/" style="text-decoration: none" draggable="false"><font color="#FFFFFF" style="color: rgba(255, 255, 255, 1);">Controllo se sei un robot...</font></a></div><div style="word-wrap:break-word;font-weight:400;font-size:11px;overflow:hidden;text-overflow:ellipsis;text-align:left;" class="lp-rich-link-captionBar-textStack-bottomCaption-leading"><a rel="nofollow" href="https://lore.kernel.org/buildroot/20251214170654.GD193459@pevik/" style="text-decoration: none" draggable="false"><font color="#FFFFFF" style="color: rgba(235, 235, 245, 0.6);">lore.kernel.org</font></a></div></div></td></tr></tbody></table></td></tr></tbody></table></a></div></div><br></div><div><br></div><div>Could you please review and double check it?</div><div><br></div><div>Best regards<br id="lineBreakAtBeginningOfSignature"><div dir="ltr">Giulio Benetti</div><div dir="ltr"><br><blockquote type="cite">Il giorno 26 dic 2025, alle ore 18:46, Dario Binacchi &lt;dario.binacchi@amarulasolutions.com&gt; ha scritto:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span>Commit 7cea8ad66aec ("Add conditional version script support") broke</span><br><span>backward compatibility for the RPC database interfaces, and indeed the</span><br><span>build of xinetd fails with the following errors:</span><br><span></span><br><span>buildroot/output/per-package/xinetd/host/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/14.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: confparse.o: in function `cnf_get':</span><br><span>buildroot/build/xinetd-2.3.15/xinetd/buildroot/build/xinetd-2.3.15/xinetd/confparse.c:990:(.text+0x34c): undefined reference to `endrpcent'</span><br><span>buildroot/output/per-package/xinetd/host/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/14.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: confparse.o: in function `check_entry':</span><br><span>buildroot/build/xinetd-2.3.15/xinetd/buildroot/build/xinetd-2.3.15/xinetd/confparse.c:752:(.text+0xeed): undefined reference to `getrpcbyname'</span><br><span>collect2: error: ld returned 1 exit status</span><br><span></span><br><span>Fixes: 3f3d6e43de9b ("package/libtirpc: bump to version 1.3.7")</span><br><span>Signed-off-by: Dario Binacchi &lt;dario.binacchi@amarulasolutions.com&gt;</span><br><span>---</span><br><span> package/libtirpc/Config.in &nbsp;&nbsp;| 6 ++++++</span><br><span> package/libtirpc/libtirpc.mk | 8 ++++++++</span><br><span> 2 files changed, 14 insertions(+)</span><br><span></span><br><span>diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in</span><br><span>index 31f1636ef5fd..e7ab2d9c1136 100644</span><br><span>--- a/package/libtirpc/Config.in</span><br><span>+++ b/package/libtirpc/Config.in</span><br><span>@@ -16,6 +16,12 @@ config BR2_PACKAGE_LIBTIRPC_GSS</span><br><span>  &nbsp; &nbsp;help</span><br><span>  &nbsp; &nbsp; &nbsp;Enable GSSAPI support</span><br><span></span><br><span>+config BR2_PACKAGE_LIBTIRPC_RPCDB</span><br><span>+ &nbsp; &nbsp;bool "rpcdb"</span><br><span>+ &nbsp; &nbsp;default y</span><br><span>+ &nbsp; &nbsp;help</span><br><span>+ &nbsp; &nbsp; &nbsp;Enable RPC Database support</span><br><span>+</span><br><span> comment "libtirpc needs a toolchain w/ threads"</span><br><span>  &nbsp; &nbsp;depends on !BR2_TOOLCHAIN_HAS_THREADS</span><br><span></span><br><span>diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk</span><br><span>index ab159545614a..a764526aaf1f 100644</span><br><span>--- a/package/libtirpc/libtirpc.mk</span><br><span>+++ b/package/libtirpc/libtirpc.mk</span><br><span>@@ -25,5 +25,13 @@ LIBTIRPC_CONF_OPTS += --disable-gssapi</span><br><span> endif</span><br><span> HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi</span><br><span></span><br><span>+ifeq ($(BR2_PACKAGE_LIBTIRPC_RPCDB),y)</span><br><span>+LIBTIRPC_CONF_OPTS += --enable-rpcdb</span><br><span>+HOST_LIBTIRPC_CONF_OPTS += --enable-rpcdb</span><br><span>+else</span><br><span>+LIBTIRPC_CONF_OPTS += --disable-rpcdb</span><br><span>+HOST_LIBTIRPC_CONF_OPTS += --disable-rpcdb</span><br><span>+endif</span><br><span>+</span><br><span> $(eval $(autotools-package))</span><br><span> $(eval $(host-autotools-package))</span><br><span>-- </span><br><span>2.43.0</span><br><span></span><br></div></blockquote></div></body></html>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:linux-amarula+unsubscribe@amarulasolutions.com">linux-amarula+unsubscribe@amarulasolutions.com</a>.<br />
'Abel Vesa' via Amarula Linux Feb. 3, 2026, 2:27 p.m. UTC | #2 
Hello,

On Fri, Dec 26, 2025 at 06:46:23PM +0100, Dario Binacchi wrote:
> Commit 7cea8ad66aec ("Add conditional version script support") broke
> backward compatibility for the RPC database interfaces, and indeed the
> build of xinetd fails with the following errors:

Thanks for your patch. Turns out we did merge another patch series for
this issue, so I'll mark your patch as Not Applicable. Sorry for
missing your patch in the first place.

Best regards,

Thomas
diff mbox series

Patch

diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 31f1636ef5fd..e7ab2d9c1136 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -16,6 +16,12 @@  config BR2_PACKAGE_LIBTIRPC_GSS
 	help
 	  Enable GSSAPI support
 
+config BR2_PACKAGE_LIBTIRPC_RPCDB
+	bool "rpcdb"
+	default y
+	help
+	  Enable RPC Database support
+
 comment "libtirpc needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
index ab159545614a..a764526aaf1f 100644
--- a/package/libtirpc/libtirpc.mk
+++ b/package/libtirpc/libtirpc.mk
@@ -25,5 +25,13 @@  LIBTIRPC_CONF_OPTS += --disable-gssapi
 endif
 HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC_RPCDB),y)
+LIBTIRPC_CONF_OPTS += --enable-rpcdb
+HOST_LIBTIRPC_CONF_OPTS += --enable-rpcdb
+else
+LIBTIRPC_CONF_OPTS += --disable-rpcdb
+HOST_LIBTIRPC_CONF_OPTS += --disable-rpcdb
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))