diff mbox series

configs: imx8mn_bsh_smm_s2: remove console from bootargs

Message ID 20230104161823.2730410-1-dario.binacchi@amarulasolutions.com
State New
Headers
Series configs: imx8mn_bsh_smm_s2: remove console from bootargs |

Commit Message

Dario Binacchi Jan. 4, 2023, 4:18 p.m. UTC 
The Linux kernel device tree already specifies the device to be used for
boot console output with a stdout-path property under /chosen.

Fixes: 36b661dc919da ("Merge branch 'next'")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 include/configs/imx8mn_bsh_smm_s2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Trimarchi Jan. 5, 2023, 8:20 a.m. UTC | #1 
Hi

On Wed, Jan 4, 2023 at 5:18 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> The Linux kernel device tree already specifies the device to be used for
> boot console output with a stdout-path property under /chosen.
>
> Fixes: 36b661dc919da ("Merge branch 'next'")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
>  include/configs/imx8mn_bsh_smm_s2.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
> index a2323bd6716f..2db670600f5a 100644
> --- a/include/configs/imx8mn_bsh_smm_s2.h
> +++ b/include/configs/imx8mn_bsh_smm_s2.h
> @@ -14,7 +14,7 @@
>  #include <config_distro_bootcmd.h>
>
>  #define NANDARGS \
> -       "nandargs=setenv bootargs console=${console} " \
> +       "nandargs=setenv bootargs " \
>                 "${optargs} " \
>                 "mtdparts=${mtdparts} " \
>                 "root=${nandroot} " \
> --
> 2.32.0
>

Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>
Michael Trimarchi Jan. 9, 2023, 2:40 p.m. UTC | #2 
Hi Tom

Did you have time to pick the regression on this board? We have two patches

Michael

On Thu, Jan 5, 2023 at 9:20 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi
>
> On Wed, Jan 4, 2023 at 5:18 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
> >
> > The Linux kernel device tree already specifies the device to be used for
> > boot console output with a stdout-path property under /chosen.
> >
> > Fixes: 36b661dc919da ("Merge branch 'next'")
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >
> >  include/configs/imx8mn_bsh_smm_s2.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
> > index a2323bd6716f..2db670600f5a 100644
> > --- a/include/configs/imx8mn_bsh_smm_s2.h
> > +++ b/include/configs/imx8mn_bsh_smm_s2.h
> > @@ -14,7 +14,7 @@
> >  #include <config_distro_bootcmd.h>
> >
> >  #define NANDARGS \
> > -       "nandargs=setenv bootargs console=${console} " \
> > +       "nandargs=setenv bootargs " \
> >                 "${optargs} " \
> >                 "mtdparts=${mtdparts} " \
> >                 "root=${nandroot} " \
> > --
> > 2.32.0
> >
>
> Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com
Tom Rini Jan. 9, 2023, 7:02 p.m. UTC | #3 
On Mon, Jan 09, 2023 at 03:40:06PM +0100, Michael Nazzareno Trimarchi wrote:

> Hi Tom
> 
> Did you have time to pick the regression on this board? We have two patches

Sorry I missed this.

> 
> Michael
> 
> On Thu, Jan 5, 2023 at 9:20 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi
> >
> > On Wed, Jan 4, 2023 at 5:18 PM Dario Binacchi
> > <dario.binacchi@amarulasolutions.com> wrote:
> > >
> > > The Linux kernel device tree already specifies the device to be used for
> > > boot console output with a stdout-path property under /chosen.
> > >
> > > Fixes: 36b661dc919da ("Merge branch 'next'")
> > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > > ---
> > >
> > >  include/configs/imx8mn_bsh_smm_s2.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
> > > index a2323bd6716f..2db670600f5a 100644
> > > --- a/include/configs/imx8mn_bsh_smm_s2.h
> > > +++ b/include/configs/imx8mn_bsh_smm_s2.h
> > > @@ -14,7 +14,7 @@
> > >  #include <config_distro_bootcmd.h>
> > >
> > >  #define NANDARGS \
> > > -       "nandargs=setenv bootargs console=${console} " \
> > > +       "nandargs=setenv bootargs " \
> > >                 "${optargs} " \
> > >                 "mtdparts=${mtdparts} " \
> > >                 "root=${nandroot} " \
> > > --
> > > 2.32.0
> > >
> >
> > Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com
> 
> 
> 
> -- 
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
> 
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com
diff mbox series

Patch

diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
index a2323bd6716f..2db670600f5a 100644
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@ -14,7 +14,7 @@ 
 #include <config_distro_bootcmd.h>
 
 #define NANDARGS \
-	"nandargs=setenv bootargs console=${console} " \
+	"nandargs=setenv bootargs " \
 		"${optargs} " \
 		"mtdparts=${mtdparts} " \
 		"root=${nandroot} " \