diff mbox series

[RESEND] configs: imx8mn_bsh_smm_s2: remove console from bootargs

Message ID 20230128160858.63171-1-dario.binacchi@amarulasolutions.com
State New
Headers
Series [RESEND] configs: imx8mn_bsh_smm_s2: remove console from bootargs |

Commit Message

Dario Binacchi Jan. 28, 2023, 4:08 p.m. UTC 
The Linux kernel device tree already specifies the device to be used for
boot console output with a stdout-path property under /chosen.

Fixes: 36b661dc919da ("Merge branch 'next'")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 include/configs/imx8mn_bsh_smm_s2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Jan. 28, 2023, 5:50 p.m. UTC | #1 
Hi Dario,

On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> The Linux kernel device tree already specifies the device to be used for
> boot console output with a stdout-path property under /chosen.
>
> Fixes: 36b661dc919da ("Merge branch 'next'")

The patch looks good, but I don't understand why this needs a Fixes tag.

Reviewed-by: Fabio Estevam <festevam@denx.de>
Dario Binacchi Jan. 29, 2023, 4:47 p.m. UTC | #2 
Hi Fabio,

On Sat, Jan 28, 2023 at 6:50 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Dario,
>
> On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
> >
> > The Linux kernel device tree already specifies the device to be used for
> > boot console output with a stdout-path property under /chosen.
> >
> > Fixes: 36b661dc919da ("Merge branch 'next'")
>
> The patch looks good, but I don't understand why this needs a Fixes tag.

The patch re-added 'console=${console}':
diff --cc include/configs/imx8mn_bsh_smm_s2.h
index d09c2ab01610,84c19824bdca..c6b296281424
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@@ -14,11 -14,8 +14,9 @@@
  #include <config_distro_bootcmd.h>

  #define NANDARGS \
-       "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
-       "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
-       "nandargs=setenv bootargs " \
+       "nandargs=setenv bootargs console=${console} " \
                "${optargs} " \
 +              "mtdparts=${mtdparts} " \
                "root=${nandroot} " \
                "rootfstype=${nandrootfstype}\0" \
        "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \

that I already removed in the commit:
bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs").
This is why I decided to add the fix tag.

Thanks and regards,
Dario

>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Fabio Estevam Jan. 29, 2023, 7:46 p.m. UTC | #3 
On Sun, Jan 29, 2023 at 1:47 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:

> The patch re-added 'console=${console}':
> diff --cc include/configs/imx8mn_bsh_smm_s2.h
> index d09c2ab01610,84c19824bdca..c6b296281424
> --- a/include/configs/imx8mn_bsh_smm_s2.h
> +++ b/include/configs/imx8mn_bsh_smm_s2.h
> @@@ -14,11 -14,8 +14,9 @@@
>   #include <config_distro_bootcmd.h>
>
>   #define NANDARGS \
> -       "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
> -       "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
> -       "nandargs=setenv bootargs " \
> +       "nandargs=setenv bootargs console=${console} " \
>                 "${optargs} " \
>  +              "mtdparts=${mtdparts} " \
>                 "root=${nandroot} " \
>                 "rootfstype=${nandrootfstype}\0" \
>         "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
>
> that I already removed in the commit:
> bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs").
> This is why I decided to add the fix tag.

Understood.

It would be nice to have such an explanation in the commit log.
diff mbox series

Patch

diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
index e97b8e871d22..deeed9c2f582 100644
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@ -14,7 +14,7 @@ 
 #include <config_distro_bootcmd.h>
 
 #define NANDARGS \
-	"nandargs=setenv bootargs console=${console} " \
+	"nandargs=setenv bootargs " \
 		"${optargs} " \
 		"mtdparts=${mtdparts} " \
 		"root=${nandroot} " \