diff mbox series

[2/2] package/libmad: drop GCC's "-fforce-mem" option

Message ID 20240702133655.2425922-2-dario.binacchi@amarulasolutions.com
State New
Headers
Series [1/2] package/libmad: update the patches to be applied with fuzz 0 |

Commit Message

Dario Binacchi July 2, 2024, 1:36 p.m. UTC 
The commit fixes the following compilation error:

    i686-buildroot-linux-gnu-gcc.br_real: error: unrecognized command-line option ‘-fforce-mem’

From GCC 4.3 release notes [1]:

    The -fforce-mem option has been removed because it has had no effect
    in the last few GCC releases.

[1] https://gcc.gnu.org/gcc-4.3/changes.html
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 .../0003-drop-GCC-fforce-mem-option.patch      | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 package/libmad/0003-drop-GCC-fforce-mem-option.patch

Comments

'Abel Vesa' via Amarula Linux July 2, 2024, 7:42 p.m. UTC | #1 
On 02/07/2024 15:36, Dario Binacchi wrote:
> The commit fixes the following compilation error:
> 
>      i686-buildroot-linux-gnu-gcc.br_real: error: unrecognized command-line option ‘-fforce-mem’
> 
>  From GCC 4.3 release notes [1]:
> 
>      The -fforce-mem option has been removed because it has had no effect
>      in the last few GCC releases.
> 
> [1] https://gcc.gnu.org/gcc-4.3/changes.html
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>   .../0003-drop-GCC-fforce-mem-option.patch      | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>   create mode 100644 package/libmad/0003-drop-GCC-fforce-mem-option.patch
> 
> diff --git a/package/libmad/0003-drop-GCC-fforce-mem-option.patch b/package/libmad/0003-drop-GCC-fforce-mem-option.patch
> new file mode 100644
> index 000000000000..dc832ac70514
> --- /dev/null
> +++ b/package/libmad/0003-drop-GCC-fforce-mem-option.patch
> @@ -0,0 +1,18 @@
> +configure.ac: drop GCC "-fforce-mem" option
> +
> +As reported at [1], the option has been removed from version 4.3 of GCC.
> +
> +[1] https://ez.analog.com/dsp/software-and-development-tools/linux-blackfin/linux-bug-archive/w/documents/7460/5626-build-lib-mad-fail-at-option--fforce-mem-with-gcc-4-3
> +Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> +Upstream: N/A [Buildroot specific]

  This is not Buildroot specific at all, anyone using libmad at this time is 
going to hit the issue.

  So I've changed this to Upstream: Dead

  Which is also not entirely true because there's a fork at [1], but OK.


  With that change, applied both to master, thanks.

  Regards,
  Arnout

[1] https://github.com/sezero/libmad


> +
> +--- libmad-0.15.1b-orig/configure.ac	2024-07-02 14:26:40.657984791 +0200
> ++++ libmad-0.15.1b/configure.ac	2024-07-02 14:27:07.098198997 +0200
> +@@ -140,7 +140,6 @@
> +     case "$optimize" in
> + 	-O|"-O "*)
> + 	    optimize="-O"
> +-	    optimize="$optimize -fforce-mem"
> + 	    optimize="$optimize -fforce-addr"
> + 	    : #x optimize="$optimize -finline-functions"
> + 	    : #- optimize="$optimize -fstrength-reduce"

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
Peter Korsgaard July 9, 2024, 5:06 p.m. UTC | #2 
>>>>> "Dario" == Dario Binacchi <dario.binacchi@amarulasolutions.com> writes:

 > The commit fixes the following compilation error:
 >     i686-buildroot-linux-gnu-gcc.br_real: error: unrecognized command-line option ‘-fforce-mem’

 > From GCC 4.3 release notes [1]:

 >     The -fforce-mem option has been removed because it has had no effect
 >     in the last few GCC releases.

 > [1] https://gcc.gnu.org/gcc-4.3/changes.html
 > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Committed to 2024.02.x and 2024.05.x, thanks.
diff mbox series

Patch

diff --git a/package/libmad/0003-drop-GCC-fforce-mem-option.patch b/package/libmad/0003-drop-GCC-fforce-mem-option.patch
new file mode 100644
index 000000000000..dc832ac70514
--- /dev/null
+++ b/package/libmad/0003-drop-GCC-fforce-mem-option.patch
@@ -0,0 +1,18 @@ 
+configure.ac: drop GCC "-fforce-mem" option 
+
+As reported at [1], the option has been removed from version 4.3 of GCC.
+
+[1] https://ez.analog.com/dsp/software-and-development-tools/linux-blackfin/linux-bug-archive/w/documents/7460/5626-build-lib-mad-fail-at-option--fforce-mem-with-gcc-4-3
+Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
+Upstream: N/A [Buildroot specific]
+
+--- libmad-0.15.1b-orig/configure.ac	2024-07-02 14:26:40.657984791 +0200
++++ libmad-0.15.1b/configure.ac	2024-07-02 14:27:07.098198997 +0200
+@@ -140,7 +140,6 @@
+     case "$optimize" in
+ 	-O|"-O "*)
+ 	    optimize="-O"
+-	    optimize="$optimize -fforce-mem"
+ 	    optimize="$optimize -fforce-addr"
+ 	    : #x optimize="$optimize -finline-functions"
+ 	    : #- optimize="$optimize -fstrength-reduce"