diff mbox series

ddr: imx: keep ddrmix_initialized out of .bss

Message ID 20261029160513.666555-1-dario.binacchi@amarulasolutions.com
State New
Headers
Series ddr: imx: keep ddrmix_initialized out of .bss |

Commit Message

Dario Binacchi Oct. 29, 2026, 4:05 p.m. UTC 
ddr_init() is called from board_init_f(), before .bss is cleared, so
ddrmix_initialized may already be non-zero on the first call. The DDRMIX
cold reset is then run on a DDRMIX that has never been initialized and
the SPL hangs (with DEBUG enabled in ddr_init.c):

  DDRINFO: start DRAM init
  DDRINFO: cold reset the DDRMIX

Move ddrmix_initialized to .data, so that it is zero on the first call.

Fixes: ae03528affd3 ("ddr: imx: Recreate the power-on state before repeating ddr_init()")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 drivers/ddr/imx/imx8m/ddr_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---
base-commit: 03e45557e1f38a39a0c80fe30483130ff376cf92
branch: imx8m-ddrmix-initialized-data

Comments

Frieder Schrempf Oct. 29, 2026, 4:17 p.m. UTC | #1 
Hi Dario,

On 29.10.26 17:05, Dario Binacchi wrote:
> ddr_init() is called from board_init_f(), before .bss is cleared, so
> ddrmix_initialized may already be non-zero on the first call. The DDRMIX
> cold reset is then run on a DDRMIX that has never been initialized and
> the SPL hangs (with DEBUG enabled in ddr_init.c):
> 
>   DDRINFO: start DRAM init
>   DDRINFO: cold reset the DDRMIX
> 
> Move ddrmix_initialized to .data, so that it is zero on the first call.
> 
> Fixes: ae03528affd3 ("ddr: imx: Recreate the power-on state before repeating ddr_init()")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

This issue didn't show up in my tests on i.MX8MM and i.MX8MP, but it
looks correct to me.

Thanks for fixing this!

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Best regards
Frieder

> 
> ---
> 
>  drivers/ddr/imx/imx8m/ddr_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ddr/imx/imx8m/ddr_init.c b/drivers/ddr/imx/imx8m/ddr_init.c
> index b2873ab439d7..154e9d887465 100644
> --- a/drivers/ddr/imx/imx8m/ddr_init.c
> +++ b/drivers/ddr/imx/imx8m/ddr_init.c
> @@ -48,7 +48,7 @@
>  #define CCGR_DDRMIX			CCGR_DDR1
>  #endif
>  
> -static bool ddrmix_initialized;
> +static bool ddrmix_initialized __section(".data");
>  
>  static unsigned int g_cdd_rr_max[4];
>  static unsigned int g_cdd_rw_max[4];
> ---
> base-commit: 03e45557e1f38a39a0c80fe30483130ff376cf92
> branch: imx8m-ddrmix-initialized-data
> 

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
Emanuele Ghidoli Oct. 29, 2026, 4:47 p.m. UTC | #2 
On 10/29/26 17:05, Dario Binacchi wrote:
> ddr_init() is called from board_init_f(), before .bss is cleared, so
> ddrmix_initialized may already be non-zero on the first call. The DDRMIX
> cold reset is then run on a DDRMIX that has never been initialized and
> the SPL hangs (with DEBUG enabled in ddr_init.c):
> 
>   DDRINFO: start DRAM init
>   DDRINFO: cold reset the DDRMIX
> 
> Move ddrmix_initialized to .data, so that it is zero on the first call.
> 
> Fixes: ae03528affd3 ("ddr: imx: Recreate the power-on state before repeating ddr_init()")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 

[...]

3 out of 6 Verdin iMX8M Plus and the SMARC iMX8M Plus SoMs in our CI farm were
hanging in SPL, this patch fixes it.

Thanks!

Emanuele

Reviewed-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Tested-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
diff mbox series

Patch

diff --git a/drivers/ddr/imx/imx8m/ddr_init.c b/drivers/ddr/imx/imx8m/ddr_init.c
index b2873ab439d7..154e9d887465 100644
--- a/drivers/ddr/imx/imx8m/ddr_init.c
+++ b/drivers/ddr/imx/imx8m/ddr_init.c
@@ -48,7 +48,7 @@ 
 #define CCGR_DDRMIX			CCGR_DDR1
 #endif
 
-static bool ddrmix_initialized;
+static bool ddrmix_initialized __section(".data");
 
 static unsigned int g_cdd_rr_max[4];
 static unsigned int g_cdd_rw_max[4];