diff mbox series

[2/9] arm64: dts: imx8mn-bsh-smm-s2-common: Leave regulator under hw state machine

Message ID 20250514082507.1983849-3-dario.binacchi@amarulasolutions.com
State New
Headers
Series DTS updates for BSH SMM S2[PRO] boards |

Commit Message

Dario Binacchi May 14, 2025, 8:24 a.m. UTC 
From: Michael Trimarchi <michael@amarulasolutions.com>

Let regulator to be controlled by hardware state machine.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Matti Vaittinen May 15, 2025, 8:54 a.m. UTC | #1 
On 14/05/2025 11:24, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
> 
> Let regulator to be controlled by hardware state machine.

Is it possible to add a note _why_ these regulators must be controlled 
by the state machine and not by the software?

> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>   arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> index 5a1ec2f6a552..0d343ffdb7f9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> @@ -144,6 +144,7 @@ buck4_reg: BUCK4 {
>   				regulator-max-microvolt = <3300000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			buck5_reg: BUCK5 {
> @@ -153,6 +154,7 @@ buck5_reg: BUCK5 {
>   				regulator-max-microvolt = <1995000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			buck6_reg: BUCK6 {
> @@ -162,6 +164,7 @@ buck6_reg: BUCK6 {
>   				regulator-max-microvolt = <1400000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			ldo1_reg: LDO1 {

Yours,
	-- Matti

To unsubscribe from this group and stop receiving emails from it, send an email to linux-amarula+unsubscribe@amarulasolutions.com.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
index 5a1ec2f6a552..0d343ffdb7f9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
@@ -144,6 +144,7 @@  buck4_reg: BUCK4 {
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
 				regulator-always-on;
+				rohm,no-regulator-enable-control;
 			};
 
 			buck5_reg: BUCK5 {
@@ -153,6 +154,7 @@  buck5_reg: BUCK5 {
 				regulator-max-microvolt = <1995000>;
 				regulator-boot-on;
 				regulator-always-on;
+				rohm,no-regulator-enable-control;
 			};
 
 			buck6_reg: BUCK6 {
@@ -162,6 +164,7 @@  buck6_reg: BUCK6 {
 				regulator-max-microvolt = <1400000>;
 				regulator-boot-on;
 				regulator-always-on;
+				rohm,no-regulator-enable-control;
 			};
 
 			ldo1_reg: LDO1 {